fix: do not omit patternProperties when properties is undefined#1203
fix: do not omit patternProperties when properties is undefined#1203theAnuragMishra wants to merge 2 commits intoasyncapi:masterfrom
Conversation
|
@AceTheCreator so you ignore the pr for a month, come and suggest a change to remove empty fragment possibility and then disappear again? If you don't like useful prs and are only interested in reviewing prs that shift a div from one place to the other, please feel free to close the pr. Don't keep someone hanging for so long for a pr that's not even 10 lines of change. |
Are you aware that your PR test failed? Please refrain from accusations like this moving forward. Thank you |
|
Also, there wasn’t a clear signal that your PR was ready for another review since the conversation hadn’t been resolved. Please don’t place the blame on me, or any maintainer, for that. It’s important we follow the process so everyone stays aligned. At the end of the day, it’s open source; let’s keep it constructive and not take things personally. |
67b0ad4 to
cec886d
Compare
|
Ok sorry. The pr was up for tooo long so i crashed out. The failing check was related to formatting which I have fixed. I think everything should be as expected now. Please have a look. |
cec886d to
28aab79
Compare
|
AceTheCreator
left a comment
There was a problem hiding this comment.
One last review @theAnuragMishra. The potential issue I see with this current implementation is that if you only want to render when there's actual data, you might want to conditionally render each map individually.
so like, |



Description
Changes proposed in this pull request:
propertiesisundefinedwhich shows nopatternPropertieseven if they are presentpropertiesandpatternPropertiesto empty objects in case they are undefined. If there's nothing to show,Object.entriesmaps nothing and nothing is rendered which is desired.patternPropertiesis omitted whenpropertiesisundefined.Related issue(s)
closes #1197