Skip to content

fix: remove button tag and keep content same for accessibility (#958) #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jerald-roy wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −2
Open

fix: remove button tag and keep content same for accessibility (#958) #1204

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b534cc
fix: remove button tag and keep content same for accessibility (#958)
jerald-roy Jan 8, 2026
5465a27
Merge branch 'master' into fix/button-focus-outline
jerald-roy Jan 23, 2026
b3ae5b2
Merge branch 'master' into fix/button-focus-outline
AceTheCreator Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions library/src/components/CollapseButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const CollapseButton: React.FunctionComponent<Props> = ({
children,
...rest
}) => (
<button
<div
{...rest}
className={`focus:ring-2 focus:ring-offset-2 focus:ring-indigo-500 ${rest.className ?? ''}`}
type="button"
Expand All @@ -43,5 +43,5 @@ export const CollapseButton: React.FunctionComponent<Props> = ({
expanded ? '-rotate-90' : ''
} ${chevronProps?.className ?? ''}`}
/>
</button>
</div>
);
Loading