Conversation
Signed-off-by: Siddhi sahu <himanisahu739@gmail.com>
|
|
Hi @Siddhi-sahu, I reviewed the PR and tested it locally. Looks good
Pending
Overall, the implementation looks solid. Let me know if you need any help with the tests or changeset. |
|
/u |
|
Please add options accordingly here https://github.com/asyncapi/cli/blob/master/src/apps/cli/internal/base/BaseGeneratorCommand.ts#L47 I don't the compile option right now does anything meaningful till it's passed to generator. |
|
thanks for your patience @Shurtu-gal . I think I understand now. You mean, compile needs to be explicitly forwarded to |
Signed-off-by: Siddhi sahu <himanisahu739@gmail.com>
|



Description
hopefully fixes #1829
I am new here, and still trying to understand the codebase.
I have opened the pr but I am not entirely sure if I am going into the right direction. Any little push would be appreciated.
Thank you for your time.
@Shurtu-gal
Related issue(s)