fix: windows release by aligning Node version with engine requirements#1983
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR aims to fix Windows release failures by aligning the CI Node.js version with the engine requirements specified in package.json (Node ≥24). The change updates the Windows asset upload workflow to use .nvmrc for determining the Node version instead of the hardcoded Node 20.
Changes:
- Updates the Windows build step in the release asset upload workflow to read Node version from
.nvmrcfile instead of using a hardcoded version
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
hey @Shurtu-gal , |
Shurtu-gal
left a comment
There was a problem hiding this comment.
Please have a look at other workflows as well in case we are missing node version fix.
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 | ||
| node-version-file: '.nvmrc' |
There was a problem hiding this comment.
I don't think we have nvmrc file.
You can use this instead.
cli/.github/workflows/release-with-changesets.yml
Lines 95 to 105 in 870eb6b
e64b696 to
e535316
Compare
e535316 to
5d34899
Compare
|
|
Sorry about that @Shurtu-gal — I missed cross-checking this earlier. I have now updated the workflow to remove the .nvmrc usage and aligned the Node version setup with the pattern used in release-with-changesets.yml. All checks are passing, and I also verified the fix locally. Could you please take another look when you have time? Thanks! |



Description
.exeartifacts.Related issue(s)
Resolves #1982