fix(generate): preserve underlying error when validating registry URL#2025
Open
Satish11012007 wants to merge 3 commits intoasyncapi:masterfrom
Open
fix(generate): preserve underlying error when validating registry URL#2025Satish11012007 wants to merge 3 commits intoasyncapi:masterfrom
Satish11012007 wants to merge 3 commits intoasyncapi:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes an issue in
registryValidationwhere the original error was swallowed and replaced with a generic message during registry URL validation.Low-level errors such as DNS failures, network timeouts, TLS/SSL issues, proxy misconfiguration, or authentication errors were previously discarded. This made troubleshooting difficult for both CLI users and automated systems.
This change preserves the original error message and attaches the original
Errorobject ascause, improving diagnosability without introducing breaking changes.Root Cause
The
catchblock inregistryValidationthrew a new genericErrorwithout preserving the original exception.As a result:
ENOTFOUND,ECONNREFUSED, TLS error, timeout) was lostChanges Introduced
Inside the
catch (err)block: