Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: add GitHub Actions guide #1872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs: add GitHub Actions guide #1872
Changes from all commits
abb53c7
e45d481
444d30e
48893ac
1a5ddd6
ffeb22d
053821f
344f28d
0e0d2bc
44f63ae
85880c3
99e6e94
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the Global replicator workflow is an action responsible for distributing other workflows in whatever repository we want. So it's important to go over all the jobs under this workflow.
Also, most of the structure of this document was decided a while ago by the community based on this thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Third duplication. Basically the same concepts are described again in slightly different words.
I would suggest combining all the introductory information into the "Introduction" or "Overview" section after the Table of Contents. A short intro before TOC looks strange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the process of maintaining this table up-to-date once any workflow gets changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question from my side
it is already not very accurate, as there is no workflow names "PTAL command" but "Please take a Look" (https://github.com/asyncapi/.github/blob/master/.github/workflows/please-take-a-look-command.yml)
imho better in overview explain how to learn about each workflow, on an example
and for good docs, rather put comments inside YAML files - the advantage is that if there is a good docs in yaml, it will be easier to maintain, and also anyone seeing a copy of such workflow in their repo - they can easily learn what it does directly from the YAML file copy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provide team name
@asyncapi/bots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provide the name so people knwo what to put in CODEOWNERS file
@asyncapi-bot-eve
and yeah, explain that code owner means someone in CODEOWNER
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not so sure it is good idea to have this table.
even now it is not up to date with what is in https://github.com/asyncapi/.github/blob/master/.github/workflows/global-replicator.yml file - long term it might event get worse
wouldn't it be better to make sure https://github.com/asyncapi/.github/blob/master/.github/workflows/global-replicator.yml has proper comments and descriptions inside YAML, and here in docs, it is explaned that there are different jobs, and how and where to find more details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be here? especially that semantic release is no longer the only standard here, we also use changeset in some monorepos