fix: replace relative links with absolute links#2072
fix: replace relative links with absolute links#2072asyncapi-bot merged 5 commits intoasyncapi:masterfrom
Conversation
WalkthroughConverted relative image paths in MEETINGS_ORGANIZATION.md to absolute GitHub blob URLs, fixed the YouTube list numbering from “-1.” to “1.” and added a short sentence in the Restream-first section. Changes are documentation-only; no code/API edits. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@thulieblack PTAL |
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/060-meetings-and-communication/MEETINGS_ORGANIZATION.md (1)
52-131: Replace GitHubblobimage URLs with raw or repository-relative paths (blob links return HTML)
HEAD checks show github.com/.../blob/... → Content-Type: text/html while raw.githubusercontent.com/... → Content-Type: image/png. Update docs/060-meetings-and-communication/MEETINGS_ORGANIZATION.md (lines 52–131) to use raw.githubusercontent.com or, preferably, repository-relative paths (e.g., assets/meetings/stream1.png) so images serve as image/* in production.
🧹 Nitpick comments (2)
docs/060-meetings-and-communication/MEETINGS_ORGANIZATION.md (2)
98-102: Minor: the inline icon width at 3% is tiny.Consider a fixed pixel width (e.g., 16–24px) or a slightly larger percentage for readability on mobile.
52-131: Optional: prefer first‑party hosting or site‑absolute paths.If the docs site can serve /assets/meetings/*, use absolute site paths instead of external GitHub hosts. Benefits: better caching, availability, and CSP compliance. Alternatively, pin to a commit SHA in raw.githubusercontent.com to avoid drift.
|
@bandantonio your review here please |
|
@animeshk923 Please apply all the suggestions from code rabbit, they are valid. Blob URLs are OK to reference source code or certain markdown files located within a repo but not rendered on the website, but images must be in the raw format suggested by code rabbit. |
Understood. |
- updated image links with raw.githubusercontent.com links - applied suggestions from coderabbit - comment ref: asyncapi#2072 (comment)
|
@bandantonio PTAL, I've made the changes required. |
|
/rtm |
|
Thank you Animesh |
My pleasure! |
Description
Related issue(s)
Fixes #2068
Summary by CodeRabbit