fix: ticket section render issue#445
Conversation
❌ Deploy Preview for peaceful-ramanujan-288045 failed.Built without sensitive environment variables
|
AceTheCreator
left a comment
There was a problem hiding this comment.
@toffee-k21 we should stick to using the existing ticket cards. We should list all the tickets and only enable the upcoming conference ticket(which should come first)
Hey @AceTheCreator, I've updated the Ticket section to show upcoming events first, followed by events ended. This functionality was already implemented |
But i think cards shouldn't have background |
Hey @AceTheCreator , I have removed the background as you mentioned |
Looks great @toffee-k21 . |
…1/conference-website into feat/add-ticket-render
@AceTheCreator, I have fixed the alignment and made the cards align in the middle |
AceTheCreator
left a comment
There was a problem hiding this comment.
@toffee-k21 i think it'll look visually appealing if the list of tickets is rendered in a carousel layout. wyt?
Great idea! Displaying tickets in this way will keep the layout compact, conserving vertical space and this will also improve readability |
AceTheCreator
left a comment
There was a problem hiding this comment.
@toffee-k21 why are you not using the slider component we already have in code?
ashmit-coder
left a comment
There was a problem hiding this comment.
Could you please demonstrate with a video how the component would look when the carousal effect is been applied.
Hey @AceTheCreator @ashmit-coder, I've implemented the card render section using the slider component. Let me know if there's anything you'd like to change! |
I have raised a new PR #478 that will resolve this issue |
Description
Ticketsection