feat: sticky hamburger menu for mobile version#460
feat: sticky hamburger menu for mobile version#460asyncapi-bot merged 8 commits intoasyncapi:masterfrom
Conversation
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Someone else is working on this PR #458 |
|
sorry my bad please continue |
|
Instead of making the navbar transparent, could we consider using a blur effect so that the content scrolling behind the navbar is not visible? |
@Mayaleeeee would have to approve this. |
that would sure look better @r3yc0n1c , thanks for the suggestion @catosaurusrex2003 |
sure! working on in... will send a PR soon |
Mayaleeeee
left a comment
There was a problem hiding this comment.
Thank you, @catosaurusrex2003
Yeah, I love the idea of a transparent nav bar @ashmit-coder
It would work better than the current one in the demo.
I like the current colour on the 2023 conference website
|
Should we also convert the solid purple color of hamburger dropdown to a translucent blur just like the navbar? like taking inspiration of navbar dropdown in mobile viewport from here https://datahack.djss4ds.in/ |
|
@r3yc0n1c do you plan on adding the suggested changes by @catosaurusrex2003 in the comment above? |
yeah sure! it looks good actually... shall I get started with the blurred menu items? |
What solid purple colour? |
I think he's referring to the dark purple background (#1B1130) we use in the navbar: |
yes, i am referring to that. Its just a suggestion @r3yc0n1c you can give it a try. |
sure! WIP |
|
here's the new update:
|
|
@r3yc0n1c this is looking cool! 🔥 I did notice a small discrepancy between browsers tho in FIREFOX 👇The in CHROME 👇The blur effect doesn’t work for the dropdown. This might be outside the scope of this PR, but I thought I’d flag it just in case! Apart from this minor issue, it’s looking great to me. @ashmit-coder @AceTheCreator @Mayaleeeee what do yall think ? |
thank you! the backdrop-blur issue is due to chrome which doesn't seem to allow nested backdrops for tailwind (ref: tailwindlabs/tailwindcss#15103)... that's why I kept the opacity as 90 to compensate this |
|
ok 👍, then lets skip that for now. |
|
/ptal |
|
@AceTheCreator @thulieblack Please take a look at this PR. Thanks! 👋 |
|
/rtm |
Co-authored-by: Cody's Dad <40604284+AceTheCreator@users.noreply.github.com>%0ACo-authored-by: Ashmit Jagtap <ashmitjagtap2209@gmail.com>%0ACo-authored-by: asyncapi-bot <bot+chan@asyncapi.io>











Description
Related issue(s)
Resolves #455
Demo
