feat: change navdrop links and sub-links style on hover#463
feat: change navdrop links and sub-links style on hover#463gauravtak wants to merge 14 commits intoasyncapi:masterfrom
Conversation
gauravtak
requested review from
AceTheCreator,
Mayaleeeee,
ashmit-coder and
thulieblack
as code owners
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
AceTheCreator
left a comment
AceTheCreator
left a comment
There was a problem hiding this comment.
Awesome enhancement contribution @gaurav-2-0-0-2, but i think a nice addition will be to show which link is currently active. wyt?
Yes I was thinking the same thing. will add changes to this PR |
|
Hey @gaurav-2-0-0-2 The second hover effects for mobile screens would look better as way of indicating where the user is as said by Ace. But I dont see a use of them in mobile view, as after clicking the links the user would simply be redirected. |
ashmit-coder
left a comment
ashmit-coder
left a comment
There was a problem hiding this comment.
Remove the changes in package-lock.json
do i need to remove package-lock.json when making a PR |
Just dont have any changes in that file |
and the page re renders and the navdrop set to what it was, do we need to highlight the sub menus here or will it be an overkill ? |
|
I don't think it will be an overkill tbh. Wyt @AceTheCreator |
|
Hey, is this enough ? |
|
hey is this going to be merged, it is showing some conflicts ? |
yes @gaurav-2-0-0-2 you have to resolve those conflicts on your local and then push the new code. Do try not to hurt the conflicting functionality and maintain your changes as well. If you need help you can ask in slack. The topic you want to look at is |
|
hey @ashmit-coder i resolved the conflicts, made a small change to make the functionality work, is it good to go now ? do suggest if any changes required. |
|
@gaurav-2-0-0-2 did you make sure not to remove the functionality that was giving conflict. tell me the name of the file that was causing the conflict. |
Yes I made sure to not remove those changes |
|
@gaurav-2-0-0-2 kindly resolve the conflict on this PR 🙏🏽 |
|
hey @AceTheCreator resolved conflicts I think you can merge now |
|
@ashmit-coder, your approval is needed 👍🏾 |
|
Pinging you on this too @ashmit-coder |
|
@AceTheCreator rtm or I can contribute? |
|
@gaurav-2-0-0-2 kindly resolve the conflicts 🙏🏽 |
ashmit-coder
left a comment
ashmit-coder
left a comment
There was a problem hiding this comment.
Hey @gaurav-2-0-0-2 sorry for the delay, if you could resolve the conflcts I will merge it asap.
|
@gauravtak kindly resolve the conflicts |
|
Conflicts where not resolved and no response from the contributor. Re-assigning the issue |
5 participants
Description
Demo
