fix: redirection Link fix#467
fix: redirection Link fix#467asyncapi-bot merged 11 commits intoasyncapi:masterfrom Karma-LLP:linkfix
Conversation
TenzDelek
requested review from
AceTheCreator,
Mayaleeeee,
ashmit-coder and
thulieblack
as code owners
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
AceTheCreator
left a comment
AceTheCreator
left a comment
There was a problem hiding this comment.
@TenzDelek, i noticed were the link is been referenced is not a button but a text, which can easily be missed. since the text is a link, then i believed it should be underlined. wyt @ashmit-coder?
agree on that, currently, the underline is kept on hover. should I go on with the changes to add a underline? |
I dont think so @AceTheCreator , the underline seems to not go well with the design of the card, hence I dont think we should add it. The hover effect looks better and the text points towards it being a link. |
|
Please link the text to the YouTube playlist https://youtube.com/playlist?list=PLbi1gRlP7pijItMBmw9SeeyWxuEa3jLR2&si=MNNU0r-aCmuWFPLI |
done |
Hmm... I actually missed that it was a link. Why not make it a button if adding an underline is gonna mess with the UI. wyt @Mayaleeeee? |
Thanks for the ping @AceTheCreator Could you please provide a screenshot of where I can find the issue on the website? @TenzDelek |
Mayaleeeee
left a comment
Mayaleeeee
left a comment
There was a problem hiding this comment.
The text (that direct users to the YouTube recording) should be in a different colour (a bright colour because of the overlay background) and underlined.
cc @TenzDelek @AceTheCreator @ashmit-coder
I think we can also use a button —since the online conference is different from the in-person ones.
Mayaleeeee
left a comment
Mayaleeeee
left a comment
There was a problem hiding this comment.
The text (that direct users to the YouTube recording) should be in a different colour (a bright colour because of the overlay background) and underlined.
cc @TenzDelek @AceTheCreator @ashmit-coder
I think we can also use a button —since the online conference is different from the in-person ones.
have underlined the link as maya suggested.
imo only underlining the text would be best. as it is an external link a button doesn't sound right . @Mayaleeeee
cc @AceTheCreator @ashmit-coder
|
|
any changes are still needed here or are we ready to merge 🤔 |
|
@TenzDelek can you update this branch, so we can merge this PR? |
done cc @AceTheCreator |
|
/rtm |
Co-authored-by: Ashmit Jagtap <ashmitjagtap2209@gmail.com>%0ACo-authored-by: asyncapi-bot <bot+chan@asyncapi.io>
6 participants
Description
fixed the youtube redirection link
Related issue(s)
Fixes #466