Skip to content

fix: resolved lint warnings#468

Merged
asyncapi-bot merged 6 commits intoasyncapi:masterfrom
SahilDahekar:lint-issues
Dec 17, 2024
Merged

fix: resolved lint warnings#468
asyncapi-bot merged 6 commits intoasyncapi:masterfrom
SahilDahekar:lint-issues

Conversation

@SahilDahekar
Copy link
Contributor

@SahilDahekar SahilDahekar commented Nov 13, 2024

Description

  • Fixed lint warning in stepThree.js & select.js files.

Related issue(s)

Fixes #328

@netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit b014768
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/676127042c0c5c00085dc551
😎 Deploy Preview https://deploy-preview-468--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AceTheCreator
AceTheCreator requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind sharing the screenshot of before and after your fix?

@SahilDahekar
Copy link
Contributor Author

SahilDahekar commented Nov 13, 2024 •
edited
Loading

Hey @AceTheCreator , here are before and after images :-

Before :
image

After :
image

@AceTheCreator
Copy link
Member

AceTheCreator commented Nov 15, 2024

@ashmit-coder your review is needed :)

@ashmit-coder
Copy link
Contributor

ashmit-coder commented Nov 15, 2024

@ashmit-coder your review is needed :)

Hey @AceTheCreator waiting for this pr #386

So that the tests are ran on this pr, just to be sure all functionalities are working.

@SahilDahekar
Copy link
Contributor Author

SahilDahekar commented Nov 22, 2024

Hey @ashmit-coder , since PR #386 is merged can we proceed with this PR.

@ashmit-coder
Copy link
Contributor

ashmit-coder commented Nov 22, 2024

Hey @ashmit-coder , since PR #386 is merged can we proceed with this PR.

Sure! Soon

@ashmit-coder
Copy link
Contributor

ashmit-coder commented Nov 27, 2024

hey @AceTheCreator ptal

@ashmit-coder
Copy link
Contributor

ashmit-coder commented Nov 27, 2024

@SahilDahekar could you confirm that there are no further warnings after the updation to the code.

@SahilDahekar
Copy link
Contributor Author

SahilDahekar commented Nov 27, 2024

No lint warnings @ashmit-coder
image

AceTheCreator
AceTheCreator approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AceTheCreator
Copy link
Member

AceTheCreator commented Dec 17, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit c380024 into asyncapi:master Dec 17, 2024
13 checks passed
@SahilDahekar SahilDahekar deleted the lint-issues branch December 17, 2024 14:21
vincenthirtz pushed a commit to vincenthirtz/conference-website that referenced this pull request Dec 19, 2025
@SahilDahekar @ashmit-coder
fix: resolved lint warnings (asyncapi#468)
1b77cb2 
Co-authored-by: Cody's Dad <40604284+AceTheCreator@users.noreply.github.com>%0ACo-authored-by: Ashmit Jagtap <ashmitjagtap2209@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AceTheCreator AceTheCreator AceTheCreator approved these changes

@thulieblack thulieblack Awaiting requested review from thulieblack thulieblack is a code owner

@Mayaleeeee Mayaleeeee Awaiting requested review from Mayaleeeee Mayaleeeee is a code owner

+1 more reviewer

@ashmit-coder ashmit-coder ashmit-coder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Resolve the existing Next.js lint issues

4 participants

@SahilDahekar @AceTheCreator @ashmit-coder @asyncapi-bot