Skip to content

fix: return to top arrow feature/button#477

Closed
techmannih wants to merge 9 commits intoasyncapi:masterfrom
techmannih:scroll
Closed

fix: return to top arrow feature/button#477
techmannih wants to merge 9 commits intoasyncapi:masterfrom
techmannih:scroll

Conversation

@techmannih
Copy link
Contributor

Description
This PR implements a "Return to top" arrow feature/button to improve user navigation. When clicked, the button smoothly scrolls the page back to the top, enhancing the user experience by providing a quick way to navigate to the top of long pages.

Related issue(s)
Issue #475
close #475

@netlify
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 947d6d2
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/678628fcbfd3510007b3ff25
😎 Deploy Preview https://deploy-preview-477--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@techmannih techmannih changed the title fix: Return to top arrow feature/button fix: return to top arrow feature/button Nov 25, 2024
@techmannih
Copy link
Contributor Author

@ashmit-coder please review this PR

@ashmit-coder
Copy link
Contributor

@techmannih please make the button available in other pages as well. Also, use some different style of arrow.

Copy link
Contributor

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the scroll.svg to something more appealing and change the colour of background as well.

@techmannih
Copy link
Contributor Author

@ashmit-coder I think white background looks good,

20241129142351.mp4

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix @techmannih

I think the background should have the background of the button below and the arrow should be white, to keep the UI consistent.

AsyncAPI-Conference-12-17-2024_08_21_AM

@ashmit-coder
Copy link
Contributor

is this pr active @techmannih ?

@techmannih
Copy link
Contributor Author

Yeah, I updated soon

@ashmit-coder
Copy link
Contributor

Yeah, I updated soon

Resolve Ace's request and update the branch

@AceTheCreator
Copy link
Member

@techmannih, sorry i'll have to close this PR, cuz there's already a pr close to completion implementing this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return to top arrow feature/button

3 participants