Skip to content

fix: sponsor and subscribe section width on home page.#480

Merged
ashmit-coder merged 9 commits intoasyncapi:masterfrom
SahilDahekar:issue_479
Jan 2, 2025
Merged

fix: sponsor and subscribe section width on home page.#480
ashmit-coder merged 9 commits intoasyncapi:masterfrom
SahilDahekar:issue_479

Conversation

@SahilDahekar
Copy link
Contributor

Description

  • Fixed sponsor and subscribe section width on home page.
    image

Related issue(s)

Fixes #479

@netlify
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit caee986
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67696ad460544000083b26c2
😎 Deploy Preview https://deploy-preview-480--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SahilDahekar could you please try and add tests for the fixes you have done in the cypress test suite. This will make sure these error dont occur in the future.

If you need help do contact me via slack.

@SahilDahekar
Copy link
Contributor Author

Okay

Copy link
Contributor

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  should render guideline for not ended cities and agenda otherwise:
         AssertionError: Timed out retrying after 4000ms: Expected to find element: `[data-test="guideline-com"]`, but never found it.

Please look into this error in the test written, its mostly due to a missing data-test tag in the guideline component.

@SahilDahekar
Copy link
Contributor Author

  should render guideline for not ended cities and agenda otherwise:
         AssertionError: Timed out retrying after 4000ms: Expected to find element: `[data-test="guideline-com"]`, but never found it.

Please look into this error in the test written, its mostly due to a missing data-test tag in the guideline component.

Below are the screenshot of the tests that were running before i made any changes to cypress e2e tests.

Screenshot from 2024-11-27 23-50-46

Screenshot from 2024-11-27 23-50-13

As we can see only the Form should work test is running but when i made changes all the 3 tests are running.

Do you want me to make changes so that only the new test that is added and Form should work tests run ?

@ashmit-coder
Copy link
Contributor

Yes @SahilDahekar the it.only was an bug from my side, I want you to make it to just it and as for the failed test can you tell me on which page is it failing.

@ashmit-coder
Copy link
Contributor

        if(Date.now()>Date(city.date) && !city.ended){
            cy.getTestData("guideline-com").should("be.visible");
        }
        else{
            cy.getTestData("agenda-com").should("be.visible");
        }

@SahilDahekar please make the changes as shown above

@SahilDahekar
Copy link
Contributor Author

@ashmit-coder Now ig everything is resolved and all test are passing.

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashmit-coder ashmit-coder merged commit ff32d9e into asyncapi:master Jan 2, 2025
12 checks passed
vincenthirtz pushed a commit to vincenthirtz/conference-website that referenced this pull request Dec 19, 2025
* Fixed width for sponsor and subscribe section on home page

* Fixed sponsor render issue on venue pages

* Added cypress test for checking sponsor logos rendering

* Imported hardcode data from city.json

* Made changes to if condition in venue.cy.js

---------

Co-authored-by: Cody's Dad <40604284+AceTheCreator@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Sponsor and Subscribe section on home page does not span full viewport width

3 participants