fix: sponsor and subscribe section width on home page.#480
fix: sponsor and subscribe section width on home page.#480ashmit-coder merged 9 commits intoasyncapi:masterfrom
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ashmit-coder
left a comment
There was a problem hiding this comment.
Hey @SahilDahekar could you please try and add tests for the fixes you have done in the cypress test suite. This will make sure these error dont occur in the future.
If you need help do contact me via slack.
|
Okay |
ashmit-coder
left a comment
There was a problem hiding this comment.
should render guideline for not ended cities and agenda otherwise:
AssertionError: Timed out retrying after 4000ms: Expected to find element: `[data-test="guideline-com"]`, but never found it.
Please look into this error in the test written, its mostly due to a missing data-test tag in the guideline component.
Below are the screenshot of the tests that were running before i made any changes to cypress e2e tests. As we can see only the Do you want me to make changes so that only the new test that is added and |
|
Yes @SahilDahekar the |
@SahilDahekar please make the changes as shown above |
|
@ashmit-coder Now ig everything is resolved and all test are passing. |
* Fixed width for sponsor and subscribe section on home page * Fixed sponsor render issue on venue pages * Added cypress test for checking sponsor logos rendering * Imported hardcode data from city.json * Made changes to if condition in venue.cy.js --------- Co-authored-by: Cody's Dad <40604284+AceTheCreator@users.noreply.github.com>


Description
Related issue(s)
Fixes #479