-
-
Notifications
You must be signed in to change notification settings - Fork 157
fix: dropdown-menu #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: dropdown-menu #545
Conversation
hey @ashmit-coder please check this PR i think it resolves the issue |
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@AceTheCreator I would like to work on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@naman9271, kindly look into your code changes, they're not well formatted
@AceTheCreator please check i have run the please review that again |
@ashmit-coder, your review is needed :) |
@ashmit-coder Kindly Review this PR |
@ashmit-coder, pinging you one more time on this PR |
Sure @AceTheCreator |
Hey @naman9271 the conference logo is not visible to me |
just fixing this failed tests |
75e8629
to
de4893d
Compare
@ashmit-coder please have a look now i have fixed the errors |
Description
This PR addresses the issue where the dropdown menu (e.g., "Venue" or navigation items) was not accessible via keyboard navigation. It ensures that keyboard users can open, close, and navigate the dropdown menu seamlessly, with proper focus indicators and ARIA attributes for accessibility.
Key Changes:
Enter
,Space
, andArrow
keys to open/close the dropdown and navigate between menu items.aria-expanded
,aria-controls
) for accessibility.Issue Reference
Fixes #544 (Replace with the actual issue number if applicable).
Steps to Reproduce (Before Fix)
Tab
key to focus on the dropdown trigger (e.g., "Venue").Enter
orSpace
to open the dropdown.Changes Made
Keyboard Event Handlers:
keydown
event listeners forEnter
ARIA Attributes:
aria-expanded
: Indicates whether the dropdown is open.aria-controls
: Links the trigger with the dropdown content.Focus Styles:
Expected Behavior (After Fix)
Enter
,Space
, or Arrow keys.Tab
.Screenshots or Video (Optional)
Before
406753703-5b687b08-9cf3-442a-af46-2454af7cfd20.mp4
After
dropmenu-fixed.mp4
Testing Instructions
Tab
key to focus on the dropdown trigger (e.g., "Venue").Enter
orSpace
to open the dropdown.ArrowUp
andArrowDown
keys to navigate menu items.Esc
to close the dropdown.Checklist
Possible Future Improvements
Reviewer Notes
Please verify:
Thank you for reviewing this PR! Let me know if you need further details or modifications.