-
-
Notifications
You must be signed in to change notification settings - Fork 157
feat(ui): add scroll to top button #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(ui): add scroll to top button #586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @Robinaditya1045!
A couple of suggestions:
The arrow could use a smoother transition when it appears for a better visual effect.
Its position seems too far off the screen, bringing it slightly toward the top and left would improve its placement.
@Robinaditya1045 maybe you lean towards this PR approach to the button style |
Sure, will work on the changes. |
Kinda, yes. |
@AceTheCreator, I have committed the suggested changes. Please review |
I think we should lean towards using this type of arrow up icon https://www.svgrepo.com/svg/93813/up-arrow |
Also the positioning on mobile resolution is a little bit disturbing 🤔 I think it should be placed toward the bottom right corner |
Hey @AceTheCreator, I have fixed the mobile responsiveness thing. Please review it. If this works, then I will move forward and clean the commit history |
LGTM! |
Hey @Robinaditya1045 dont you think we should have the illustration it as a svg file rather than an editable js file. |
Hey @ashmit-coder, I have made the required changes |
Hey @Robinaditya1045 I am sorry for the mis understanding on my end, but you can revert back to your older changes, as thats the theme we were following. |
Sure! |
@ashmit-coder reverted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Description
Related Issue(s)
Fixes #475
Testing
Screenshots