Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speaker filter and sessiontype filter for agenda component #595

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

om2137
Copy link

@om2137 om2137 commented Mar 10, 2025

Description

  • I have tested the code for the edge cases.
  • This PR add filters to the agenda list for better User Experience
filters.mp4

Related issue(s)
Resolves #562

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f736ff2
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67ceb95a449a2400084c25d2
😎 Deploy Preview https://deploy-preview-595--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f86ba63
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67da76d2159b6f000819e2ae
😎 Deploy Preview https://deploy-preview-595--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashmit-coder
Copy link
Collaborator

Hey @Mayaleeeee could you look into the design.

@ashmit-coder
Copy link
Collaborator

@om2137 could you add cypress test for this functionality as well/

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@om2137, we'll have to wait for @Mayaleeeee's input regarding the styling before moving forward

@Jaishree2310
Copy link

Jaishree2310 commented Mar 17, 2025

Hi @om2137, I would like to suggest some feedback on this.
Can you design all three buttons to have the same consistency and the drop-down icon needs proper spacing between the box border? Also, the drop-down box to get some corner radius.
This will help the good UI/UX design for the button.

@ashmit-coder
Copy link
Collaborator

Hi @om2137, I would like to suggest some feedback on this. Can you design all three buttons to have the same consistency and the drop-down icon needs proper spacing between the box border? Also, the drop-down box to get some corner radius. This will help the good UI/UX design for the button.

@Jaishree2310 would be better suggested to @Mayaleeeee cause she is the decision maker for the design part.

@Jaishree2310
Copy link

Hi @om2137, I would like to suggest some feedback on this. Can you design all three buttons to have the same consistency and the drop-down icon needs proper spacing between the box border? Also, the drop-down box to get some corner radius. This will help the good UI/UX design for the button.

@Jaishree2310 would be better suggested to @Mayaleeeee cause she is the decision maker for the design part.

Yes, I was helping with the design, but yes, the final decision will be of Maya.

@om2137
Copy link
Author

om2137 commented Mar 18, 2025

Hi @om2137, I would like to suggest some feedback on this. Can you design all three buttons to have the same consistency and the drop-down icon needs proper spacing between the box border? Also, the drop-down box to get some corner radius. This will help the good UI/UX design for the button.

@Jaishree2310 would be better suggested to @Mayaleeeee cause she is the decision maker for the design part.

Yes, I was helping with the design, but yes, the final decision will be of Maya.

I am also waiting for @Mayaleeeee review before making any changes

@om2137
Copy link
Author

om2137 commented Mar 19, 2025

@om2137 could you add cypress test for this functionality as well/

@ashmit-coder have pushed a test let me know if i should make any changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Agenda Enhancements ( filters for agenda )
4 participants