Skip to content

feat: speaker filter and sessiontype filter for agenda component #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

om2137
Copy link

@om2137 om2137 commented Mar 10, 2025

Description

  • I have tested the code for the edge cases.
  • This PR add filters to the agenda list for better User Experience
filters.mp4

Related issue(s)
Resolves #562

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f736ff2
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67ceb95a449a2400084c25d2
😎 Deploy Preview https://deploy-preview-595--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit cc81fd5
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67f3bba3bb3f13000827a247
😎 Deploy Preview https://deploy-preview-595--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashmit-coder
Copy link
Collaborator

Hey @Mayaleeeee could you look into the design.

@ashmit-coder
Copy link
Collaborator

@om2137 could you add cypress test for this functionality as well/

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@om2137, we'll have to wait for @Mayaleeeee's input regarding the styling before moving forward

@Jaishree2310
Copy link
Contributor

Jaishree2310 commented Mar 17, 2025

Hi @om2137, I would like to suggest some feedback on this.
Can you design all three buttons to have the same consistency and the drop-down icon needs proper spacing between the box border? Also, the drop-down box to get some corner radius.
This will help the good UI/UX design for the button.

@ashmit-coder
Copy link
Collaborator

Hi @om2137, I would like to suggest some feedback on this. Can you design all three buttons to have the same consistency and the drop-down icon needs proper spacing between the box border? Also, the drop-down box to get some corner radius. This will help the good UI/UX design for the button.

@Jaishree2310 would be better suggested to @Mayaleeeee cause she is the decision maker for the design part.

@Jaishree2310
Copy link
Contributor

Hi @om2137, I would like to suggest some feedback on this. Can you design all three buttons to have the same consistency and the drop-down icon needs proper spacing between the box border? Also, the drop-down box to get some corner radius. This will help the good UI/UX design for the button.

@Jaishree2310 would be better suggested to @Mayaleeeee cause she is the decision maker for the design part.

Yes, I was helping with the design, but yes, the final decision will be of Maya.

@om2137
Copy link
Author

om2137 commented Mar 18, 2025

Hi @om2137, I would like to suggest some feedback on this. Can you design all three buttons to have the same consistency and the drop-down icon needs proper spacing between the box border? Also, the drop-down box to get some corner radius. This will help the good UI/UX design for the button.

@Jaishree2310 would be better suggested to @Mayaleeeee cause she is the decision maker for the design part.

Yes, I was helping with the design, but yes, the final decision will be of Maya.

I am also waiting for @Mayaleeeee review before making any changes

@om2137
Copy link
Author

om2137 commented Mar 19, 2025

@om2137 could you add cypress test for this functionality as well/

@ashmit-coder have pushed a test let me know if i should make any changes

@AceTheCreator
Copy link
Member

@om2137, i can't seem to figure out how to find your suggested changes in the preview deployment

@om2137
Copy link
Author

om2137 commented Mar 24, 2025

@om2137, i can't seem to figure out how to find your suggested changes in the preview deployment

Hey @AceTheCreator As there are no agendas currently live, I am afraid we cannot test filters in preview.
In dev mode I changed the Jsons on venue page to 2024's Jsons to make these filters.
Until there are any agenda for any venue of 2025 live I don't think we can test the changes in preview.

If there is any way you can suggest? I can quickly implement it

@AceTheCreator
Copy link
Member

@Mayaleeeee we really need your design opinion here 🙏🏽

@RamGoel would really need some design guidance

@om2137
Copy link
Author

om2137 commented Apr 26, 2025

Are there any changes required on this from my side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Agenda Enhancements ( filters for agenda )
4 participants