Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make Code of Conduct button visible on small screens #597

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

PiyushY111
Copy link
Contributor

@PiyushY111 PiyushY111 commented Mar 10, 2025

This PR fixes a bug where the Code of Conduct button in the footer was not visible on small screens (below 790px width). The issue was caused by the sm:hidden class, which prevented the button from rendering on smaller devices.Additionally,Updated the global styles (global.css) by cleaning unnecessary styles that are commented.

Related Issue:
fixes #594

Testing=

  1. Open the website in mobile view .
  2. Check if the Code of Conduct button appears correctly.
Screen.Recording.2025-03-11.at.12.28.42.AM.mov

@ashmit-coder @AceTheCreator Please review this pr

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f64526b
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67dd1e71a8db4600081c5419
😎 Deploy Preview https://deploy-preview-597--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PiyushY111 PiyushY111 changed the title Responsiveness of Code of Conduct Button(Bug-#594) Responsiveness of Code of Conduct Button(Bug #594) Mar 10, 2025
@PiyushY111 PiyushY111 changed the title Responsiveness of Code of Conduct Button(Bug #594) Responsiveness of Code of Conduct Button(#594) Mar 10, 2025
@PiyushY111 PiyushY111 changed the title Responsiveness of Code of Conduct Button(#594) fix: Make Code of Conduct button visible on small screens(#594) Mar 10, 2025
@PiyushY111 PiyushY111 changed the title fix: Make Code of Conduct button visible on small screens(#594) fix: Make Code of Conduct button visible on small screens Mar 10, 2025
@PiyushY111 PiyushY111 changed the title fix: Make Code of Conduct button visible on small screens fix: make Code of Conduct button visible on small screens Mar 10, 2025
@AceTheCreator
Copy link
Member

@PiyushY111, I'm closing this PR, cuz there's already an open PR for it

@AceTheCreator
Copy link
Member

@PiyushY111, I'm closing this PR, cuz there's already an open PR for it

I noticed you were the one who opened the PR, so i have to close other and keep this open 😄

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PiyushY111, I noticed a lot of changes that aren't related to this PR...

Kindly fix them

@PiyushY111
Copy link
Contributor Author

@AceTheCreator I have fixed the issues. Kindly review

@PiyushY111
Copy link
Contributor Author

PiyushY111 commented Mar 17, 2025

@AceTheCreator @ashmit-coder I had fixed the issues. Kindly review

Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Code of Conduct Button Not Visible on Small Screens
3 participants