-
-
Notifications
You must be signed in to change notification settings - Fork 157
feat: star on github button #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@ashmit-coder, @Mayaleeeee, @AceTheCreator, please do let me know if any changes are required. |
can we try the button with a transparent white bg too? |
Sure, done, you can check now with the changes and also with hover effect. |
Let me check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Jaishree2310 is react-icons
really needed, please use a svg in place.
I will remove this!👍 |
@Mayaleeeee any suggestions ? |
@Jaishree2310 fix this ![]() |
Hey @vishvamsinh28 , I am not able to see this fix. |
Option 1: Option 2: Option 3: This is looking good! |
Can check the latest preview for the animation effect on the star button @Mayaleeeee |
I’m honestly not sure why we need this 🤨 Staring this project doesn’t seem necessary to me at this point, so this change feels a bit redundant. If we do end up implementing it eventually, I wouldn’t consider it a priority and definitely not something that should be featured in the navbar. It might make more sense to place it in the footer instead. |
Hi @AceTheCreator, I noticed that many conference websites include a "Star" button, which subtly boosts the positive perception of the project at first glance. Some of our community members have shared similar feedback and even suggested some design ideas for it. After discussing with the maintainers and @Mayaleeeee, I’ve gone ahead and opened this issue for us to track the suggestion: #582 Appreciate your thoughts on this! Thanks so much! 🙌 |
@Mayaleeeee, would love to hear your review as well. |
@Mayaleeeee @thulieblack @AceTheCreator |
@Mayaleeeee, please take a look. |
A star on GitHub Button was created to encourage more users to star the project.
Related to issue #582