Skip to content

feat: star on github button #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Jaishree2310
Copy link
Contributor

A star on GitHub Button was created to encourage more users to star the project.
Related to issue #582

Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d374316
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67f293c47ae55700081340d9
😎 Deploy Preview https://deploy-preview-663--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaishree2310
Copy link
Contributor Author

@ashmit-coder, @Mayaleeeee, @AceTheCreator, please do let me know if any changes are required.

@Mayaleeeee
Copy link
Member

@ashmit-coder, @Mayaleeeee, @AceTheCreator, please do let me know if any changes are required.

can we try the button with a transparent white bg too?

@Jaishree2310
Copy link
Contributor Author

Jaishree2310 commented Mar 28, 2025

@ashmit-coder, @Mayaleeeee, @AceTheCreator, please do let me know if any changes are required.

can we try the button with a transparent white bg too?

Sure, done, you can check now with the changes and also with hover effect.

@Mayaleeeee
Copy link
Member

@ashmit-coder, @Mayaleeeee, @AceTheCreator, please do let me know if any changes are required.

can we try the button with a transparent white bg too?

Sure, done, you can check now with the changes and also with hover effect.

Let me check

Copy link
Collaborator

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Jaishree2310 is react-icons really needed, please use a svg in place.

@Jaishree2310
Copy link
Contributor Author

Hey @Jaishree2310 is react-icons really needed, please use a svg in place.

I will remove this!👍

@Jaishree2310
Copy link
Contributor Author

@ashmit-coder, @Mayaleeeee, @AceTheCreator, please do let me know if any changes are required.

can we try the button with a transparent white bg too?

Sure, done, you can check now with the changes and also with hover effect.

Let me check

@Mayaleeeee any suggestions ?

@vishvamsinh28
Copy link
Collaborator

@Jaishree2310 fix this

Screenshot 2025-04-03 at 12 02 33 PM

@Jaishree2310
Copy link
Contributor Author

Jaishree2310 commented Apr 3, 2025

@Jaishree2310 fix this

Screenshot 2025-04-03 at 12 02 33 PM

Hey @vishvamsinh28 , I am not able to see this fix.
Can you please check again?

@Jaishree2310
Copy link
Contributor Author

image

@Jaishree2310
Copy link
Contributor Author

Jaishree2310 commented Apr 4, 2025

Option 1:

image

Option 2:

image

Option 3:

image

This is looking good!
wdyt @Mayaleeeee ?

@Jaishree2310
Copy link
Contributor Author

Jaishree2310 commented Apr 6, 2025

Can check the latest preview for the animation effect on the star button @Mayaleeeee

@AceTheCreator
Copy link
Member

I’m honestly not sure why we need this 🤨

Staring this project doesn’t seem necessary to me at this point, so this change feels a bit redundant.

If we do end up implementing it eventually, I wouldn’t consider it a priority and definitely not something that should be featured in the navbar.

It might make more sense to place it in the footer instead.

cc @ashmit-coder

@Jaishree2310
Copy link
Contributor Author

Jaishree2310 commented Apr 7, 2025

I’m honestly not sure why we need this 🤨

Staring this project doesn’t seem necessary to me at this point, so this change feels a bit redundant.

If we do end up implementing it eventually, I wouldn’t consider it a priority and definitely not something that should be featured in the navbar.

It might make more sense to place it in the footer instead.

cc @ashmit-coder

Hi @AceTheCreator,

I noticed that many conference websites include a "Star" button, which subtly boosts the positive perception of the project at first glance. Some of our community members have shared similar feedback and even suggested some design ideas for it.

After discussing with the maintainers and @Mayaleeeee, I’ve gone ahead and opened this issue for us to track the suggestion: #582

Appreciate your thoughts on this!

Thanks so much! 🙌

@Jaishree2310
Copy link
Contributor Author

@Mayaleeeee, would love to hear your review as well.

@Jaishree2310
Copy link
Contributor Author

@Mayaleeeee @thulieblack @AceTheCreator
Do we need a star on GitHub button?

@Jaishree2310
Copy link
Contributor Author

@Mayaleeeee, please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants