Skip to content

refactor: restructure footer layout #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Aksshay88
Copy link
Contributor

image

Resolves #636

Existing Pr closed (This is the old pr for the restructure footer layout )

#654

Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 95d71ad
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67f3b6158fe7e80009efb7da
😎 Deploy Preview https://deploy-preview-698--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Aksshay88 Aksshay88 changed the title refactor:restructure footer layout refactor: restructure footer layout Apr 4, 2025
@Aksshay88
Copy link
Contributor Author

@thulieblack I have made the respective changes for the footer layout.
I have closed the existing pr because it is too clumsy , So thought of opening a new pr for a neat codebase
Any changes I am willing to do . Kindly review the PR
Thank you !!!

@thulieblack
Copy link
Member

@vishvamsinh28 @Mayaleeeee @AceTheCreator thoughts

@vishvamsinh28
Copy link
Collaborator

@thulieblack the footer looks really beautiful.

@Aksshay88 I have some suggestions: The Follow us is not properly aligned with the left side of the footer. It’s slightly more towards the bottom. Could you bring it up a little bit and align it properly with the logo in the footer? Also, why are there 100+ lines of code commented out in the footer file?

Screenshot 2025-04-04 at 5 46 34 PM

@Aksshay88
Copy link
Contributor Author

@thulieblack the footer looks really beautiful.

@Aksshay88 I have some suggestions: The Follow us is not properly aligned with the left side of the footer. It’s slightly more towards the bottom. Could you bring it up a little bit and align it properly with the logo in the footer? Also, why are there 100+ lines of code commented out in the footer file?
Screenshot 2025-04-04 at 5 46 34 PM

@vishvamsinh28 sure will do the changes and update you ASAP
sorry that commented code was the existing one . I forgot to check that one . will remove that one
Thank you !!!

@Aksshay88
Copy link
Contributor Author

image

@vishvamsinh28 Kindly look into this one
I have made the changes and kindly review the PR .
Thank you !!!

@vishvamsinh28
Copy link
Collaborator

@Aksshay88 Bring the Follow Us section up a bit more, and you need to fix the footer for the mobile version.

Screenshot 2025-04-04 at 10 14 04 PM

@Aksshay88
Copy link
Contributor Author

@vishvamsinh28 yeah sure will do the changes and update you ASAP
Thank you !!!

@vishvamsinh28
Copy link
Collaborator

@Aksshay88 LGTM

@thulieblack @Mayaleeeee what do you think?

@AceTheCreator
Copy link
Member

Nah, this doesn't look good to me. The one we currently have looks simple and intuitive... The only changes we should make is the element alignment on different screen sizes.

cc @Mayaleeeee

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should focus on the footer content responsiveness, not redesign :)

@Aksshay88
Copy link
Contributor Author

We should focus on the footer content responsiveness, not redesign :)

Okay then Will focus on the alignment for different screen size

Thank you for your feedback ☺️ @AceTheCreator

@Recxsmacx
Copy link
Contributor

@AceTheCreator is this design finalized?

@AceTheCreator
Copy link
Member

@AceTheCreator is this design finalized?

We are not introducing a new design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Footer Updated
5 participants