-
-
Notifications
You must be signed in to change notification settings - Fork 156
refactor: restructure footer layout #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@thulieblack I have made the respective changes for the footer layout. |
@vishvamsinh28 @Mayaleeeee @AceTheCreator thoughts |
@thulieblack the footer looks really beautiful. @Aksshay88 I have some suggestions: The Follow us is not properly aligned with the left side of the footer. It’s slightly more towards the bottom. Could you bring it up a little bit and align it properly with the logo in the footer? Also, why are there 100+ lines of code commented out in the footer file? ![]() |
@vishvamsinh28 sure will do the changes and update you ASAP |
@vishvamsinh28 Kindly look into this one |
@Aksshay88 Bring the Follow Us section up a bit more, and you need to fix the footer for the mobile version. ![]() |
@vishvamsinh28 yeah sure will do the changes and update you ASAP |
@Aksshay88 LGTM @thulieblack @Mayaleeeee what do you think? |
Nah, this doesn't look good to me. The one we currently have looks simple and intuitive... The only changes we should make is the element alignment on different screen sizes. cc @Mayaleeeee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should focus on the footer content responsiveness, not redesign :)
Okay then Will focus on the alignment for different screen size Thank you for your feedback |
@AceTheCreator is this design finalized? |
We are not introducing a new design |
Resolves #636
Existing Pr closed (This is the old pr for the restructure footer layout )
#654