Skip to content

feat: improve Lighthouse score by optimizing performance, accessibility #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Recxsmacx
Copy link
Contributor

@Recxsmacx Recxsmacx commented Apr 4, 2025

fixes #677
This pull request aims to improve the Lighthouse score of the AsyncAPI conference website by optimizing image formats. Specifically, all occurrences of PNG images have been converted to WebP format.

Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6cdb82f
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/67f3af85abedf40008e387d6
😎 Deploy Preview https://deploy-preview-699--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Recxsmacx Recxsmacx changed the title Improve Lighthouse score by optimizing performance, accessibility feat: Improve Lighthouse score by optimizing performance, accessibility Apr 4, 2025
@Recxsmacx Recxsmacx changed the title feat: Improve Lighthouse score by optimizing performance, accessibility feat: improve Lighthouse score by optimizing performance, accessibility Apr 4, 2025
@Recxsmacx
Copy link
Contributor Author

image

@Recxsmacx
Copy link
Contributor Author

427851432-cbbb60d3-2627-4fbd-afa6-ce2b95f1c8da.png

Past results of the lcp score>

@Recxsmacx
Copy link
Contributor Author

@AceTheCreator @ashmit-coder > checkout this if there are any changes?

@AceTheCreator
Copy link
Member

@Recxsmacx, can i see the previous lighthouse scores?

@Recxsmacx
Copy link
Contributor Author

@AceTheCreator this is the lcp score 427851432-cbbb60d3-2627-4fbd-afa6-ce2b95f1c8da (1).png

@Recxsmacx
Copy link
Contributor Author

0.9s is the score after the changes and the previous one is 19800ms

@AceTheCreator
Copy link
Member

I'd love to see the previous screenshots... More like before and after

@Recxsmacx
Copy link
Contributor Author

Okay just a second

@Recxsmacx
Copy link
Contributor Author

428287332-ff8abec3-55f4-46dd-8477-7b74f4c1a4ad.png

428830088-83ac6633-0a25-4120-a28f-15ed05d5ef5b.png

@Recxsmacx
Copy link
Contributor Author

@AceTheCreator before and after changes

@AceTheCreator
Copy link
Member

428287332-ff8abec3-55f4-46dd-8477-7b74f4c1a4ad.png

428830088-83ac6633-0a25-4120-a28f-15ed05d5ef5b.png

Are these before?

@AceTheCreator
Copy link
Member

Can you label it properly so i can know which is before and which after?

@Recxsmacx
Copy link
Contributor Author

Before
428287332-ff8abec3-55f4-46dd-8477-7b74f4c1a4ad.png

After
428830088-83ac6633-0a25-4120-a28f-15ed05d5ef5b.png

@AceTheCreator
Copy link
Member

You're testing on localhost, you also need to test on your deployment url :)

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have changes in package.lock and package.json

@Recxsmacx
Copy link
Contributor Author

Already done @AceTheCreator the lcp score is resolved in it

@AceTheCreator
Copy link
Member

Already done @AceTheCreator the lcp score is resolved in it

Can i see the result :)

@Recxsmacx
Copy link
Contributor Author

430313671-2e5bcc4e-00ba-4c8a-bdce-77f4543c868e.png

Improvement of the lighthouse score requires a lot of changes the most important one was the lcp and fcp score which is solved in this pr

@Recxsmacx
Copy link
Contributor Author

Why do you have changes in package.lock and package.json

The inclusion of lucide-react is likely to enhance the iconography used in the project, improving the visual quality and possibly the performance of the website by leveraging lightweight and easily customizable icons.

@Recxsmacx Recxsmacx requested a review from AceTheCreator April 7, 2025 11:41
@Recxsmacx
Copy link
Contributor Author

Recxsmacx commented Apr 7, 2025

this issue was based on resolving the lcp and fcp score and accessibility and performance
image

@Recxsmacx
Copy link
Contributor Author

this issue was based on resolving the lcp and fcp score and accessibility and performance image

@AceTheCreator now check this>

@AceTheCreator
Copy link
Member

light-res

This is the result i'm getting while testing on your deploy url 🤔

@Recxsmacx
Copy link
Contributor Author

@AceTheCreator can you share me the complete analysis??? Like on my machine it's perfectly fine and on the deploy preview too

@Recxsmacx
Copy link
Contributor Author

430918608-39308182-b1c3-44bd-a736-ca49b26b38be.png

@Recxsmacx
Copy link
Contributor Author

image

@AceTheCreator idk how but the deploy preview scores are this > RECENT

@Recxsmacx
Copy link
Contributor Author

@AceTheCreator now it's fine??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Improve Largest Contentful Paint (LCP) by optimizing image loading
3 participants