chore: add @Adi-204 to CODEOWNERS as templates champion that joins maintainers list#1685
Conversation
derberg
requested review from
asyncapi-bot-eve,
jonaslagoni and
magicmatatjahu
as code owners
|
WalkthroughAdded a CODEOWNERS file with core maintainers, ownership for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
What reviewer looks at during PR reviewThe following are ideal points maintainers look for during review. Reviewing these points yourself beforehand can help streamline the review process and reduce time to merge.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
CODEOWNERS (1)
12-15: Optional: avoid single point of failure for packages/If Adi is OOO, PRs touching only
packages/will request only @Adi-204. Consider adding one or more core maintainers as backup owners.Example change within this block:
-packages/ @Adi-204 +packages/ @Adi-204 @derberg @magicmatatjahu @jonaslagoni
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
CODEOWNERS(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Test generator as dependency with Node 18
- GitHub Check: Test generator as dependency with Node 20
- GitHub Check: Acceptance tests for generated templates
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - ubuntu-latest
- GitHub Check: Test NodeJS PR - macos-13
🔇 Additional comments (2)
CODEOWNERS (2)
9-11: LGTM: Default owners entry is valid and well-placedWildcard rule is correctly specified and located before more specific patterns. No issues.
9-11: Sanity check: Code Owners + branch protection with a bot accountIf “Require review from Code Owners” is enabled, ensure each effective pattern includes at least one human owner so the requirement can be satisfied. Current rules do (humans are present for
*,packages/, and*.md), so this is likely fine—just confirming intent with @asyncapi-bot-eve listed.
Added CODEOWNERS entry for changeset markdown files.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
CODEOWNERS (1)
12-18: *Fix precedence so Markdown under packages/ doesn’t get claimed by the later .md ruleGitHub applies “last match wins.” With
packages/defined above*.md, anypackages/**/*.mdwill match both and end up owned by the later*.mdrule, which drops@Adi-204from reviews of template docs insidepackages/. Adjust order or add an explicit override.Option A (preferred): move the
*.mdblock abovepackages/.-# Packages directory -# @Adi-204 is Templates Champion -packages/ @Adi-204 @derberg @magicmatatjahu - -# All .md files -# @Florence-Njeri is Docs Champion -*.md @Florence-Njeri @derberg @asyncapi-bot-eve +# All .md files +# @Florence-Njeri is Docs Champion +*.md @Florence-Njeri @derberg @asyncapi-bot-eve + +# Packages directory +# @Adi-204 is Templates Champion +packages/ @Adi-204 @derberg @magicmatatjahuOption B: keep current order and add a specific override after the
*.mdrule.# All .md files # @Florence-Njeri is Docs Champion *.md @Florence-Njeri @derberg @asyncapi-bot-eve + +# Ensure Markdown under packages/ stays with Templates Champion +packages/**/*.md @Adi-204 @derberg @magicmatatjahuRun this quick check to see how many Markdown files live under
packages/(illustrates impact):#!/bin/bash set -euo pipefail echo "CODEOWNERS (relevant lines with numbers):" nl -ba CODEOWNERS | sed -n '1,120p' echo echo "Sample Markdown files under packages/:" fd --type f --extension md packages | head -n 50
🧹 Nitpick comments (2)
CODEOWNERS (2)
12-15: Confirm intended reviewer set for packages/
packages/owners are@Adi-204 @derberg @magicmatatjahuwhile default owners include@jonaslagoni @asyncapi-bot-evetoo. If you want all Core Maintainers plus the Templates Champion on package changes, consider aligning.Proposed (only if broader coverage is desired):
-packages/ @Adi-204 @derberg @magicmatatjahu +packages/ @Adi-204 @derberg @magicmatatjahu @jonaslagoni @asyncapi-bot-eve
17-18: Optional: cover uppercase .MD filesIf the repo might contain
*.MD, switch to a case-insensitive bracket pattern.-*.md @Florence-Njeri @derberg @asyncapi-bot-eve +*.[mM][dD] @Florence-Njeri @derberg @asyncapi-bot-eve
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
CODEOWNERS(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Test NodeJS PR - ubuntu-latest
- GitHub Check: Test NodeJS PR - windows-latest
- GitHub Check: Test NodeJS PR - macos-13
🔇 Additional comments (2)
CODEOWNERS (2)
20-21: *LGTM: .changeset override correctly supersedes .mdPlacing
.changeset/**/*.mdafter*.mdensures docs champions aren’t auto-requested for changesets. This ordering is correct and intentional.
9-11: Clarify scope: should @Adi-204 join the default owners as well?PR text says “joins maintainers list as a templates champion.” If that’s scoped only to
packages/, current setup is fine. If the intent is to include as a default owner, add them to*.-* @derberg @magicmatatjahu @jonaslagoni @asyncapi-bot-eve +* @derberg @magicmatatjahu @jonaslagoni @asyncapi-bot-eve @Adi-204
|
|
/rtm |
|
@allcontributors please add @Adi-204 for maintainance |
|
I couldn't determine any contributions to add, did you specify any contributions? |
|
@allcontributors please add @Adi-204 for maintenance |
|
I've put up a pull request to add @Adi-204! 🎉 |
3 participants
@Adi-204 proved over the last couple of months that he deserves the trust to join the project and share its responsibility. He's the main driver of the change that takes place in the repo, related to templates development and is alrady in the position to accept and merge related PRs. He acted as triager of issues and PRs over the last few months like a pro!
Summary by CodeRabbit