ci: update of files from global .github repo#1721
Conversation
asyncapi-bot
requested review from
asyncapi-bot-eve,
derberg,
jonaslagoni and
magicmatatjahu
as code owners
|
WalkthroughRefactors multiple GitHub Actions workflows to route context values (e.g., github.actor, github.event.) through step-level environment variables and reference them via process.env or env. in scripts/inputs. Also adjusts transfer-issue parsing/outputs and standardizes release announcement steps, including author extraction and Twitter credentials. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.github/workflows/bounty-program-commands.yml (2)
26-29: Incorrect boolean expression for allow/deny list of actors.
('aeworxet' || 'thulieblack')evaluates to'aeworxet', so checks ignorethulieblack. Use explicit comparisons.Apply this diff:
- github.actor != ('aeworxet' || 'thulieblack') && + github.actor != 'aeworxet' && github.actor != 'thulieblack' && @@ - github.actor == ('aeworxet' || 'thulieblack') && + (github.actor == 'aeworxet' || github.actor == 'thulieblack') && @@ - github.actor == ('aeworxet' || 'thulieblack') && + (github.actor == 'aeworxet' || github.actor == 'thulieblack') &&Also applies to: 54-57, 95-98
119-124: Wrong parameter type for issues.removeLabel.
namemust be a string, not an array. Current call will 422.Apply this diff:
- github.rest.issues.removeLabel({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - name: [BOUNTY_PROGRAM_LABELS[0].name] - }) + github.rest.issues.removeLabel({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + name: BOUNTY_PROGRAM_LABELS[0].name + })
🧹 Nitpick comments (1)
.github/workflows/help-command.yml (1)
36-36: Typo in user-facing help text.“reviewrs” ➜ “reviewers”.
Apply this diff:
- - `/please-take-a-look` or `/ptal` - This comment will add a comment to the PR asking for attention from the reviewrs who have not reviewed the PR yet. + - `/please-take-a-look` or `/ptal` - This comment will add a comment to the PR asking for attention from the reviewers who have not reviewed the PR yet.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/workflows/automerge-for-humans-add-ready-to-merge-or-do-not-merge-label.yml(2 hunks).github/workflows/bounty-program-commands.yml(1 hunks).github/workflows/help-command.yml(3 hunks).github/workflows/issues-prs-notifications.yml(3 hunks).github/workflows/release-announcements.yml(2 hunks).github/workflows/transfer-issue.yml(2 hunks)
🔇 Additional comments (14)
.github/workflows/bounty-program-commands.yml (2)
36-37: Good switch to step-scoped env for actor.Passing ACTOR via env avoids template interpolation inside script and keeps things consistent across workflows.
41-45: LGTM: using process.env for actor in messages.The change is correct and consistent with actions/github-script usage.
.github/workflows/automerge-for-humans-add-ready-to-merge-or-do-not-merge-label.yml (1)
30-32: Env-scoped actor usage looks good.Using
GITHUB_ACTORvia env and referencing it in the comment body is correct and consistent.Also applies to: 61-68
.github/workflows/transfer-issue.yml (2)
26-27: Quoting the awk extraction and output is safer.Prevents word-splitting and odd-body surprises when parsing the comment.
58-63: Switch to env variables for gh transfer is correct.Quoting args and using GH_TOKEN/GITHUB_TOKEN for gh is the right pattern.
Please confirm
ghis available on the selected runner image (it is on ubuntu-latest) and that the repo-scopedGITHUB_TOKENhas issue transfer permissions in this org..github/workflows/help-command.yml (2)
18-20: Actor via env for PR path: OK.Clean usage of
process.env.ACTORand consistent with other workflows.Also applies to: 30-41
49-51: Actor via env for Issue path: OK.Same pattern as PR path; looks good.
Also applies to: 58-67
.github/workflows/release-announcements.yml (4)
22-28: Step-local env + with: usage looks fine.Using step env to build the markdown input for the action is clear and localized.
71-75: Release type detection via semver-diff: OK.Using PREV_VERSION/LAST_VERSION env and emitting to
$GITHUB_OUTPUTis correct.
77-80: Author extraction improved.Multi-line run with safe printf to
$GITHUB_OUTPUTis robust.
86-92: Twitter status via env is fine; verify secrets exist.The interpolation is correct. Ensure
TWITTER_ACCESS_TOKEN_SECRETis configured in this repo..github/workflows/issues-prs-notifications.yml (3)
26-32: Issue: step-scoped env feeding markdown input looks good.Pattern is consistent with other workflows.
Confirm slackify-markdown handles empty or very long issue bodies gracefully; Slack messages shouldn’t exceed practical limits.
48-54: PR: same env-to-input pattern looks good.No concerns.
70-76: Discussion: same env-to-input pattern looks good.No concerns.
| SLACK_WEBHOOK: ${{ secrets.SLACK_RELEASES }} | ||
| SLACK_TITLE: Release ${{github.event.release.tag_name}} for ${{github.repository}} is out in the wild 😱💪🍾🎂 | ||
| SLACK_TITLE: Release ${{ env.RELEASE_TAG }} for ${{ env.REPO_NAME }} is out in the wild 😱💪🍾🎂 | ||
| SLACK_MESSAGE: ${{steps.markdown.outputs.text}} | ||
| MSG_MINIMAL: true | ||
| RELEASE_TAG: ${{github.event.release.tag_name}} | ||
| REPO_NAME: ${{github.repository}} | ||
|
|
There was a problem hiding this comment.
Expression timing bug: referencing step env inside the same env block.
SLACK_TITLE uses ${{ env.RELEASE_TAG }} and ${{ env.REPO_NAME }} defined in the same step’s env:. These won’t be available at expression-evaluation time, resulting in an empty title. Use GitHub context directly.
Apply this diff:
- SLACK_TITLE: Release ${{ env.RELEASE_TAG }} for ${{ env.REPO_NAME }} is out in the wild 😱💪🍾🎂
+ SLACK_TITLE: Release ${{ github.event.release.tag_name }} for ${{ github.repository }} is out in the wild 😱💪🍾🎂Optional: If you want to keep using env vars, promote RELEASE_TAG and REPO_NAME to job‑level env: or compute SLACK_TITLE in a prior step and export via $GITHUB_OUTPUT.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| SLACK_WEBHOOK: ${{ secrets.SLACK_RELEASES }} | |
| SLACK_TITLE: Release ${{github.event.release.tag_name}} for ${{github.repository}} is out in the wild 😱💪🍾🎂 | |
| SLACK_TITLE: Release ${{ env.RELEASE_TAG }} for ${{ env.REPO_NAME }} is out in the wild 😱💪🍾🎂 | |
| SLACK_MESSAGE: ${{steps.markdown.outputs.text}} | |
| MSG_MINIMAL: true | |
| RELEASE_TAG: ${{github.event.release.tag_name}} | |
| REPO_NAME: ${{github.repository}} | |
| SLACK_WEBHOOK: ${{ secrets.SLACK_RELEASES }} | |
| SLACK_TITLE: Release ${{ github.event.release.tag_name }} for ${{ github.repository }} is out in the wild 😱💪🍾🎂 | |
| SLACK_MESSAGE: ${{steps.markdown.outputs.text}} | |
| MSG_MINIMAL: true | |
| RELEASE_TAG: ${{github.event.release.tag_name}} | |
| REPO_NAME: ${{github.repository}} |
🤖 Prompt for AI Agents
.github/workflows/release-announcements.yml lines 31-37: SLACK_TITLE references
${ env.RELEASE_TAG } and ${ env.REPO_NAME } defined in the same step env, which
are not available at expression-evaluation time; fix by directly using GitHub
context expressions in SLACK_TITLE (e.g. use ${{ github.event.release.tag_name
}} and ${{ github.repository }}) or move RELEASE_TAG and REPO_NAME into the
job-level env so they are evaluated earlier, or compute SLACK_TITLE in a prior
step and export it via GITHUB_OUTPUT for use here.
|
/rtm |
3 participants
Summary by CodeRabbit
Bug Fixes
Refactor
Chores