docs: remove deprecated methods from API docs#1755
docs: remove deprecated methods from API docs#1755asyncapi-bot merged 5 commits intoasyncapi:masterfrom
Conversation
|
What reviewer looks at during PR reviewThe following are ideal points maintainers look for during review. Reviewing these points yourself beforehand can help streamline the review process and reduce time to merge.
|
WalkthroughAdds three Handlebars templates for member indexing (grouped and list) plus a children wrapper, updates the docs generation script to include them (removing the prior Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
derberg
left a comment
There was a problem hiding this comment.
description of PR doesn't match the changes
also please provide:
- original handlebars as comment for review of things that changed
- explain why 3 handlebars had to be modified, which parts exactly and why
|
All changes follow the same idea that is to wrap existing logic with Template 1:
|
|
🚀 Docs preview deployed |
|
|
🚀 Docs preview deployed |
I've updated it more descriptive while being to the point. However, earlier coderabbit automatically generated a misleading summary at the bottom that characterises this as an "enhancement" with "new organisational templates," when it's actually a straightforward bug fix that filters out deprecated methods to resolve broken links.please see: https://691aac44c4ab620eec8f1dd3--asyncapi-website.netlify.app/docs/tools/generator/api |
derberg
left a comment
There was a problem hiding this comment.
lgtm, I like the approach, removing deprecated from docs is also good
|
/rtm |



Description
Type: Bug Fix
Fixes broken TOC link for deprecated method
generator.generateFromStringby filtering deprecated methods from generated API documentation.Problem:
~~text~~)~character broke URL anchors (e.g.,#~~generatorgeneratefromstring~~)Solution:
@deprecatedmember-index-list.hbs- Filters list-format TOCmember-index-grouped.hbs- Filters grouped-format TOC (used by Generator class)members.hbs- Filters documentation contentpackage.jsondocs script to use new templatesapi.mdwithout deprecated methodsRef: #1755 (comment)
Result:
@deprecatedmethod automatically filtered)Testing:
screen recording
screen_compressed.mp4
Resolves #1634