Skip to content

test: add test coverage for Constructor#1949

Merged
asyncapi-bot merged 3 commits intoasyncapi:masterfrom
Harsh16gupta:test/Constructor-1887
Feb 8, 2026
Merged

test: add test coverage for Constructor#1949
asyncapi-bot merged 3 commits intoasyncapi:masterfrom
Harsh16gupta:test/Constructor-1887

Conversation

@Harsh16gupta
Copy link
Contributor

@Harsh16gupta Harsh16gupta commented Feb 7, 2026

Description
Adds comprehensive integration tests for the Constructor component in the Java Quarkus WebSocket client template.

Related Issue
Fixes #1887

image

Summary by CodeRabbit

  • Tests
    • Added an integration test suite for the WebSocket Constructor component.
    • Covers rendering behavior when query parameters are null, when they are empty, and when valid query parameters are present.
    • Ensures test setup parses the AsyncAPI fixture and prepares channels/query parameters prior to running the scenarios.

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2026

⚠️ No Changeset found

Latest commit: 48569ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@asyncapi-bot
Copy link
Contributor

What reviewer looks at during PR review

The following are ideal points maintainers look for during review. Reviewing these points yourself beforehand can help streamline the review process and reduce time to merge.

  1. PR Title: Use a concise title that follows our Conventional Commits guidelines and clearly summarizes the change using imperative mood (it means spoken or written as if giving a command or instruction, like "add new helper for listing operations")

    Note - In Generator, prepend feat: or fix: in PR title only when PATCH/MINOR release must be triggered.

  2. PR Description: Clearly explain the issue being solved, summarize the changes made, and mention the related issue.

    Note - In Generator, we use Maintainers Work board to track progress. Ensure the PR Description includes Resolves #<issue-number> or Fixes #<issue-number> this will automatically close the linked issue when the PR is merged and helps automate the maintainers workflow.

  3. Documentation: Update the relevant Generator documentation to accurately reflect the changes introduced in the PR, ensuring users and contributors have up-to-date guidance.

  4. Comments and JSDoc: Write clear and consistent JSDoc comments for functions, including parameter types, return values, and error conditions, so others can easily understand and use the code.

  5. DRY Code: Ensure the code follows the Don't Repeat Yourself principle. Look out for duplicate logic that can be reused.

  6. Test Coverage: Ensure the new code is well-tested with meaningful test cases that pass consistently and cover all relevant edge cases.

  7. Commit History: Contributors should avoid force-pushing as much as possible. It makes it harder to track incremental changes and review the latest updates.

  8. Template Design Principles Alignment: While reviewing template-related changes in the packages/ directory, ensure they align with the Assumptions and Principles. If any principle feels outdated or no longer applicable, start a discussion these principles are meant to evolve with the project.

  9. Reduce Scope When Needed: If an issue or PR feels too large or complex, consider splitting it and creating follow-up issues. Smaller, focused PRs are easier to review and merge.

  10. Bot Comments: As reviewers, check that contributors have appropriately addressed comments or suggestions made by automated bots. If there are bot comments the reviewer disagrees with, react to them or mark them as resolved, so the review history remains clear and accurate.

@coderabbitai
Copy link

coderabbitai bot commented Feb 7, 2026

📝 Walkthrough

Walkthrough

Adds a new integration test suite for the WebSocket Constructor component in the Java Quarkus template that parses an AsyncAPI fixture and verifies rendering behavior for null, empty, and valid query props.

Changes

Cohort / File(s) Summary
Constructor Component Tests
packages/templates/clients/websocket/java/quarkus/test/components/Constructor.test.js
Adds a new test file that parses an AsyncAPI YAML fixture in beforeAll, extracts channels and query parameters, and includes three tests: renders nothing for null or empty query and renders the Constructor when valid query parameters exist (with snapshot assertions).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'test: add test coverage for Constructor' follows Conventional Commits format with the 'test:' prefix, uses imperative mood, and clearly summarizes the change of adding tests for the Constructor component.
Linked Issues check ✅ Passed The PR successfully implements comprehensive test coverage for the Constructor.js component [#1887], including tests for null query props, empty query parameters, and valid parameters, directly addressing the issue's requirement for component-level test coverage.
Out of Scope Changes check ✅ Passed All changes are directly scoped to adding test coverage for the Constructor component [#1887]; no unrelated modifications or out-of-scope changes were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In
`@packages/templates/clients/websocket/java/quarkus/test/components/Constructor.test.js`:
- Around line 6-11: The file has unintended double blank lines around the setup
lines creating Parser and resolving asyncapiFilePath; remove the extra empty
lines so there is a single blank line (or none) between the top imports and the
lines "const parser = new Parser();" and between that and "const
asyncapiFilePath = path.resolve(...)" to satisfy the no-multiple-empty-lines
rule; update the block containing Parser and asyncapiFilePath to have only
single spacing.
🧹 Nitpick comments (1)
packages/templates/clients/websocket/java/quarkus/test/components/Constructor.test.js (1)

13-21: parsedAsyncAPIDocument and channels are unused outside beforeAll.

parsedAsyncAPIDocument is assigned but never read after line 19, and channels is only used to derive queryParams. You can scope them locally inside beforeAll and keep only queryParams at the describe level.

Proposed simplification
 describe('Constructor component (integration with AsyncAPI document)', () => {
-  let parsedAsyncAPIDocument;
-  let channels;
   let queryParams;
 
   beforeAll(async () => {
     const parseResult = await fromFile(parser, asyncapiFilePath).parse();
-    parsedAsyncAPIDocument = parseResult.document;
-    channels = parsedAsyncAPIDocument.channels();
+    const parsedAsyncAPIDocument = parseResult.document;
+    const channels = parsedAsyncAPIDocument.channels();
     queryParams = getQueryParams(channels);
   });

@Adi-204 Adi-204 self-assigned this Feb 8, 2026
@Adi-204 Adi-204 moved this to In Progress in Maintainers work Feb 8, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2026

@Adi-204
Copy link
Member

Adi-204 commented Feb 8, 2026

/rtm

@asyncapi-bot asyncapi-bot merged commit 2be7c9a into asyncapi:master Feb 8, 2026
15 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Maintainers work Feb 8, 2026
@Harsh16gupta Harsh16gupta deleted the test/Constructor-1887 branch February 8, 2026 12:10
Harsh16gupta added a commit to Harsh16gupta/generator that referenced this pull request Feb 9, 2026
Co-authored-by: Harsh Gupta <harsh16official@gmail.com>
Co-authored-by: Adi Boghawala <adiboghawala@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[TEST] Add component tests for Constructor.js (Java WebSocket Template)

3 participants