Skip to content

test: add test coverage for InitConnector #1951

Merged
asyncapi-bot merged 1 commit intoasyncapi:masterfrom
Harsh16gupta:test/InitConnector-1928
Feb 8, 2026
Merged

test: add test coverage for InitConnector #1951
asyncapi-bot merged 1 commit intoasyncapi:masterfrom
Harsh16gupta:test/InitConnector-1928

Conversation

@Harsh16gupta
Copy link
Contributor

@Harsh16gupta Harsh16gupta commented Feb 8, 2026

Description
Adds comprehensive integration tests for the InitConnector component in the Java Quarkus WebSocket client template.

Related Issue
Fixes #1928

image

Summary by CodeRabbit

  • Tests
    • Added comprehensive integration tests for the InitConnector component with multiple scenarios to ensure reliability and correct behavior under various input conditions.

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2026

⚠️ No Changeset found

Latest commit: 0fb2367

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@asyncapi-bot
Copy link
Contributor

What reviewer looks at during PR review

The following are ideal points maintainers look for during review. Reviewing these points yourself beforehand can help streamline the review process and reduce time to merge.

  1. PR Title: Use a concise title that follows our Conventional Commits guidelines and clearly summarizes the change using imperative mood (it means spoken or written as if giving a command or instruction, like "add new helper for listing operations")

    Note - In Generator, prepend feat: or fix: in PR title only when PATCH/MINOR release must be triggered.

  2. PR Description: Clearly explain the issue being solved, summarize the changes made, and mention the related issue.

    Note - In Generator, we use Maintainers Work board to track progress. Ensure the PR Description includes Resolves #<issue-number> or Fixes #<issue-number> this will automatically close the linked issue when the PR is merged and helps automate the maintainers workflow.

  3. Documentation: Update the relevant Generator documentation to accurately reflect the changes introduced in the PR, ensuring users and contributors have up-to-date guidance.

  4. Comments and JSDoc: Write clear and consistent JSDoc comments for functions, including parameter types, return values, and error conditions, so others can easily understand and use the code.

  5. DRY Code: Ensure the code follows the Don't Repeat Yourself principle. Look out for duplicate logic that can be reused.

  6. Test Coverage: Ensure the new code is well-tested with meaningful test cases that pass consistently and cover all relevant edge cases.

  7. Commit History: Contributors should avoid force-pushing as much as possible. It makes it harder to track incremental changes and review the latest updates.

  8. Template Design Principles Alignment: While reviewing template-related changes in the packages/ directory, ensure they align with the Assumptions and Principles. If any principle feels outdated or no longer applicable, start a discussion these principles are meant to evolve with the project.

  9. Reduce Scope When Needed: If an issue or PR feels too large or complex, consider splitting it and creating follow-up issues. Smaller, focused PRs are easier to review and merge.

  10. Bot Comments: As reviewers, check that contributors have appropriately addressed comments or suggestions made by automated bots. If there are bot comments the reviewer disagrees with, react to them or mark them as resolved, so the review history remains clear and accurate.

@coderabbitai
Copy link

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

Introduces a new component test file for the InitConnector React component in the Java Quarkus WebSocket template. The test file exercises the component across four scenarios: null, undefined, empty array, and populated queryParamsArray values, with snapshot assertions for each case.

Changes

Cohort / File(s) Summary
InitConnector Component Tests
packages/templates/clients/websocket/java/quarkus/test/components/InitConnector.test.js
New test file with four test cases covering queryParamsArray handling (null, undefined, empty array, and with data). Uses AsyncAPI fixtures and snapshot assertions to validate component rendering across different states.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows Conventional Commits format with 'test:' prefix and clearly describes adding test coverage for InitConnector in imperative mood.
Linked Issues check ✅ Passed The PR successfully adds comprehensive integration tests for InitConnector component, exercising its conditional logic with multiple test scenarios covering null, undefined, empty, and populated query parameters.
Out of Scope Changes check ✅ Passed The single file change (InitConnector.test.js) is directly scoped to the stated objective of adding component tests for InitConnector with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
packages/templates/clients/websocket/java/quarkus/test/components/InitConnector.test.js (2)

16-26: Add a guard to surface parse failures early.

If the fixture file is missing or contains invalid AsyncAPI, parseResult.document will be null and every test will fail with a confusing error (e.g., Cannot read properties of null). A simple assertion after parsing makes failures obvious.

Proposed fix
   beforeAll(async () => {
     const parseResult = await fromFile(parser, asyncapiFilePath).parse();
     parsedAsyncAPIDocument = parseResult.document;
+
+    expect(parsedAsyncAPIDocument).toBeDefined();
 
     channels = parsedAsyncAPIDocument.channels();

60-69: Test 4 may duplicate test 1 if the fixture lacks query parameters.

If the fixture's channels don't define query parameters, queryParamsArray will be null (Line 22), making this test identical to the "queryParamsArray is null" case. Verify the fixture includes query-parameterized channels, or add an assertion that queryParamsArray is non-null and non-empty before this test runs.

Suggested guard
   test('renders without TimedConnection when queryParamsArray has data from fixture', () => {
+    expect(queryParamsArray).not.toBeNull();
+    expect(queryParamsArray.length).toBeGreaterThan(0);
     const result = render(

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2026

@Adi-204
Copy link
Member

Adi-204 commented Feb 8, 2026

/rtm

@asyncapi-bot asyncapi-bot merged commit 40df7bd into asyncapi:master Feb 8, 2026
31 checks passed
@Harsh16gupta Harsh16gupta deleted the test/InitConnector-1928 branch February 8, 2026 14:35
Harsh16gupta added a commit to Harsh16gupta/generator that referenced this pull request Feb 9, 2026
Co-authored-by: Harsh Gupta <harsh16official@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TEST] Add component tests for InitConnector.js (Java WebSocket Template)

3 participants