Skip to content

test: add test coverage for ClientDependencies#1952

Merged
asyncapi-bot merged 2 commits intoasyncapi:masterfrom
Harsh16gupta:test/ClientDependencies-1929
Feb 9, 2026
Merged

test: add test coverage for ClientDependencies#1952
asyncapi-bot merged 2 commits intoasyncapi:masterfrom
Harsh16gupta:test/ClientDependencies-1929

Conversation

@Harsh16gupta
Copy link
Contributor

@Harsh16gupta Harsh16gupta commented Feb 8, 2026

Description
Adds comprehensive integration tests for the ClientDependencies component in the Java Quarkus WebSocket client template.

Related Issue
Fixes #1929

image

Summary by CodeRabbit

  • Tests
    • Added integration tests for the ClientDependencies component to verify correct rendering across multiple parameter scenarios.

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2026

⚠️ No Changeset found

Latest commit: 2e58dfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@asyncapi-bot
Copy link
Contributor

What reviewer looks at during PR review

The following are ideal points maintainers look for during review. Reviewing these points yourself beforehand can help streamline the review process and reduce time to merge.

  1. PR Title: Use a concise title that follows our Conventional Commits guidelines and clearly summarizes the change using imperative mood (it means spoken or written as if giving a command or instruction, like "add new helper for listing operations")

    Note - In Generator, prepend feat: or fix: in PR title only when PATCH/MINOR release must be triggered.

  2. PR Description: Clearly explain the issue being solved, summarize the changes made, and mention the related issue.

    Note - In Generator, we use Maintainers Work board to track progress. Ensure the PR Description includes Resolves #<issue-number> or Fixes #<issue-number> this will automatically close the linked issue when the PR is merged and helps automate the maintainers workflow.

  3. Documentation: Update the relevant Generator documentation to accurately reflect the changes introduced in the PR, ensuring users and contributors have up-to-date guidance.

  4. Comments and JSDoc: Write clear and consistent JSDoc comments for functions, including parameter types, return values, and error conditions, so others can easily understand and use the code.

  5. DRY Code: Ensure the code follows the Don't Repeat Yourself principle. Look out for duplicate logic that can be reused.

  6. Test Coverage: Ensure the new code is well-tested with meaningful test cases that pass consistently and cover all relevant edge cases.

  7. Commit History: Contributors should avoid force-pushing as much as possible. It makes it harder to track incremental changes and review the latest updates.

  8. Template Design Principles Alignment: While reviewing template-related changes in the packages/ directory, ensure they align with the Assumptions and Principles. If any principle feels outdated or no longer applicable, start a discussion these principles are meant to evolve with the project.

  9. Reduce Scope When Needed: If an issue or PR feels too large or complex, consider splitting it and creating follow-up issues. Smaller, focused PRs are easier to review and merge.

  10. Bot Comments: As reviewers, check that contributors have appropriately addressed comments or suggestions made by automated bots. If there are bot comments the reviewer disagrees with, react to them or mark them as resolved, so the review history remains clear and accurate.

@coderabbitai
Copy link

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

Adds a new test file for the ClientDependencies component in the Java Quarkus WebSocket template. The test uses snapshot testing to verify correct rendering across four scenarios with different queryParams values (null, undefined, empty Map, populated Map).

Changes

Cohort / File(s) Summary
ClientDependencies Test
packages/templates/clients/websocket/java/quarkus/test/components/ClientDependencies.test.js
New integration test file with snapshot tests for four queryParams scenarios, using @asyncapi/parser utilities to load and parse AsyncAPI fixtures.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title uses the 'test:' prefix in Conventional Commits format and clearly summarizes the change in imperative mood, indicating test coverage addition for ClientDependencies.
Linked Issues check ✅ Passed The PR adds comprehensive test coverage for ClientDependencies.js component via snapshot tests across multiple scenarios, directly fulfilling the requirement from issue #1929 to add component-level tests for this component.
Out of Scope Changes check ✅ Passed All changes are contained to a single new test file for ClientDependencies; no unrelated modifications or out-of-scope changes are present in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
packages/templates/clients/websocket/java/quarkus/test/components/ClientDependencies.test.js (1)

15-20: Consider validating the parse result before accessing .document.

If the fixture file is missing or malformed, parseResult.document will be undefined, and parsedAsyncAPIDocument.channels() will throw a cryptic TypeError rather than a clear diagnostic. A guard makes failures easier to diagnose.

Proposed improvement
   beforeAll(async () => {
     const parseResult = await fromFile(parser, asyncapiFilePath).parse();
+    expect(parseResult.diagnostics.filter(d => d.severity === 0)).toEqual([]);
     parsedAsyncAPIDocument = parseResult.document;
     channels = parsedAsyncAPIDocument.channels();
     queryParams = getQueryParams(channels);
   });

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2026

@Adi-204 Adi-204 self-assigned this Feb 9, 2026
@Adi-204 Adi-204 moved this to In Progress in Maintainers work Feb 9, 2026
Copy link
Member

@Adi-204 Adi-204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Adi-204
Copy link
Member

Adi-204 commented Feb 9, 2026

/rtm

@asyncapi-bot asyncapi-bot merged commit 2d23c7e into asyncapi:master Feb 9, 2026
18 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Maintainers work Feb 9, 2026
@Harsh16gupta Harsh16gupta deleted the test/ClientDependencies-1929 branch February 9, 2026 17:35
Harsh16gupta added a commit to Harsh16gupta/generator that referenced this pull request Feb 9, 2026
Co-authored-by: Harsh Gupta <harsh16official@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[TEST] Add component tests for ClientDependencies.js (Java WebSocket Template)

3 participants