Skip to content

test: add snapshot tests for CoreMethods readme component#1954

Merged
asyncapi-bot merged 2 commits intoasyncapi:masterfrom
SHUBHANSHU602:test-installation-CoreMethod
Feb 11, 2026
Merged

test: add snapshot tests for CoreMethods readme component#1954
asyncapi-bot merged 2 commits intoasyncapi:masterfrom
SHUBHANSHU602:test-installation-CoreMethod

Conversation

@SHUBHANSHU602
Copy link
Contributor

@SHUBHANSHU602 SHUBHANSHU602 commented Feb 8, 2026

What was added

  • tests for CoreMethods readme component
  • Covers both supported languages (javascript, python)
  • Explicitly verifies error behavior for unsupported or missing language
image

Resolves #1965

Summary by CodeRabbit

  • Tests
    • Enhanced test coverage for language support validation, ensuring reliability across JavaScript and Python implementations and proper error handling for unsupported languages.

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2026

⚠️ No Changeset found

Latest commit: c53d58e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@asyncapi-bot
Copy link
Contributor

What reviewer looks at during PR review

The following are ideal points maintainers look for during review. Reviewing these points yourself beforehand can help streamline the review process and reduce time to merge.

  1. PR Title: Use a concise title that follows our Conventional Commits guidelines and clearly summarizes the change using imperative mood (it means spoken or written as if giving a command or instruction, like "add new helper for listing operations")

    Note - In Generator, prepend feat: or fix: in PR title only when PATCH/MINOR release must be triggered.

  2. PR Description: Clearly explain the issue being solved, summarize the changes made, and mention the related issue.

    Note - In Generator, we use Maintainers Work board to track progress. Ensure the PR Description includes Resolves #<issue-number> or Fixes #<issue-number> this will automatically close the linked issue when the PR is merged and helps automate the maintainers workflow.

  3. Documentation: Update the relevant Generator documentation to accurately reflect the changes introduced in the PR, ensuring users and contributors have up-to-date guidance.

  4. Comments and JSDoc: Write clear and consistent JSDoc comments for functions, including parameter types, return values, and error conditions, so others can easily understand and use the code.

  5. DRY Code: Ensure the code follows the Don't Repeat Yourself principle. Look out for duplicate logic that can be reused.

  6. Test Coverage: Ensure the new code is well-tested with meaningful test cases that pass consistently and cover all relevant edge cases.

  7. Commit History: Contributors should avoid force-pushing as much as possible. It makes it harder to track incremental changes and review the latest updates.

  8. Template Design Principles Alignment: While reviewing template-related changes in the packages/ directory, ensure they align with the Assumptions and Principles. If any principle feels outdated or no longer applicable, start a discussion these principles are meant to evolve with the project.

  9. Reduce Scope When Needed: If an issue or PR feels too large or complex, consider splitting it and creating follow-up issues. Smaller, focused PRs are easier to review and merge.

  10. Bot Comments: As reviewers, check that contributors have appropriately addressed comments or suggestions made by automated bots. If there are bot comments the reviewer disagrees with, react to them or mark them as resolved, so the review history remains clear and accurate.

@coderabbitai
Copy link

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

A new test suite for the CoreMethods component is introduced with three test cases: rendering for JavaScript and Python languages with snapshots, and validating that an error is thrown when the language prop is missing or unsupported.

Changes

Cohort / File(s) Summary
CoreMethods Test Suite
packages/components/test/components/CoreMethods.test.js
Added three test cases for the CoreMethods component: snapshot tests for "javascript" and "python" languages, and an error expectation test for unsupported languages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding snapshot tests for the CoreMethods component, follows Conventional Commits format with 'test:' prefix, and uses imperative mood.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Adi-204 Adi-204 self-assigned this Feb 11, 2026
@Adi-204 Adi-204 moved this to In Progress in Maintainers work Feb 11, 2026
@sonarqubecloud
Copy link

@Adi-204
Copy link
Member

Adi-204 commented Feb 11, 2026

/rtm

@asyncapi-bot asyncapi-bot merged commit e43f7e9 into asyncapi:master Feb 11, 2026
14 of 15 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Maintainers work Feb 11, 2026
@derberg derberg moved this from Done to Archive in Maintainers work Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Archive

Development

Successfully merging this pull request may close these issues.

[test]:missing test for README template components CoreMethods

3 participants