-
-
Notifications
You must be signed in to change notification settings - Fork 381
feat: update @npmcli/arborist #1966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Julusian
wants to merge
7
commits into
asyncapi:master
Choose a base branch
from
Julusian:feat/update-npmcli-arborist
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8,319
−11,182
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
eeb73c9
fix: update @npmcli/arborist
Julusian 9adaa1e
chore: update babel-jest to match jest
Julusian 58b1067
chore: update types/jest and ts-jest to match
Julusian 6502439
fix jest usage
Julusian 0be64c7
fix: try adding ws
Julusian 9592efd
chore: remove unused jest-esm-transformer
Julusian aeb0bc2
update changeset
Julusian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@asyncapi/generator": patch | ||
| --- | ||
|
|
||
| Update @npmcli/arborist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: asyncapi/generator
Length of output: 2911
🌐 Web query:
@npmcli/arborist v5 v6 v7 v8 v9 breaking changes migration guide💡 Result:
@npmcli/arboristmajor-version breaking changes (v5 → v9) + what to dov5 (released 2022-02-24)
@npmcli/arborist@5.0.0in the release information I could access (it lists features/fixes only). Treat the v4→v5 jump as “potentially breaking” and regression-test your dependency-tree workflows. [1]v6 (2022)
Breaking changes
^14.17.0 || ^16.13.0 || >=18.0.0. [2]--install-strategy--global-styledeprecated;--globalnow implies--install-strategy=shallow--legacy-bundlingdeprecated; now implies--install-strategy=nested[3]Migration checklist
--global-style/--legacy-bundlingwith explicit--install-strategy={hoisted|nested|shallow}and revalidate install layout expectations. [3]v7 (2023-10-06)
7.0.0release notes I could access (they only show the release being triggered). Still, treat it as a semver-major: upgrade and run your test suite against real installs/lockfiles. [4]v8 (2024-10-03)
Breaking changes
^18.17.0 || >=20.5.0. [5]Migration checklist
v9 (2024-11 pre-releases; 2024-12 GA)
Breaking changes (from v9.0.0-pre.0)
--ignore-scriptsnow applies to all lifecycle scripts, includingprepare. [6]^20.17.0 || >=22.9.0. [6]Breaking changes (from v9.0.0-pre.1)
latestdist-tag, the publish flow retrieves prior versions and requires the version being published to be above the latest semver version in the registry (excluding prereleases). [7]Migration checklist
--ignore-scriptsexpectingprepareto still run, adjust pipelines (eg, run build steps explicitly). [6]Quick “one-shot” upgrade advice (v5 → v9)
^20.17.0 || >=22.9.0). [6]--install-strategy(and stop relying on deprecated flags). [3]--ignore-scriptsand any publish automation/versioning assumptions. [6][7]Sources: [1] [2] [3] [4] [5] [6] [7]
Note the pinning strategy change and ensure the upgrade is tested before merge.
The version jump from 5.6.3 to ^9.2.0 includes a change in pinning strategy: the old version was exactly pinned while the new one allows automatic minor/patch updates within 9.x. While the specific Arborist APIs actually used in the generator (constructor and
reify()method) don't show breaking changes across major versions, the 4-version jump should be validated in testing before merge. The Node requirement for v9 (^20.17.0 || >=22.9.0) is satisfied by the upgrade to >=24.11.🤖 Prompt for AI Agents