Skip to content

test: add test coverage for ConstructorSignature#1968

Merged
asyncapi-bot merged 3 commits intoasyncapi:masterfrom
Harsh16gupta:test/ConstructorSignature-1930
Feb 11, 2026
Merged

test: add test coverage for ConstructorSignature#1968
asyncapi-bot merged 3 commits intoasyncapi:masterfrom
Harsh16gupta:test/ConstructorSignature-1930

Conversation

@Harsh16gupta
Copy link
Contributor

@Harsh16gupta Harsh16gupta commented Feb 9, 2026

Description
Adds comprehensive integration tests for the ConstructorSignature component in the Java Quarkus WebSocket client template.

Related Issue
Fixes #1930

image

Summary by CodeRabbit

Release Notes

  • Tests
    • Added comprehensive integration tests for component rendering that validate multiple parameter configurations. Test suite covers scenarios with null, undefined, empty, and populated parameter sets using fixture-based data and snapshot comparison verification to ensure component behavior consistency.

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2026

⚠️ No Changeset found

Latest commit: 00af562

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@asyncapi-bot
Copy link
Contributor

What reviewer looks at during PR review

The following are ideal points maintainers look for during review. Reviewing these points yourself beforehand can help streamline the review process and reduce time to merge.

  1. PR Title: Use a concise title that follows our Conventional Commits guidelines and clearly summarizes the change using imperative mood (it means spoken or written as if giving a command or instruction, like "add new helper for listing operations")

    Note - In Generator, prepend feat: or fix: in PR title only when PATCH/MINOR release must be triggered.

  2. PR Description: Clearly explain the issue being solved, summarize the changes made, and mention the related issue.

    Note - In Generator, we use Maintainers Work board to track progress. Ensure the PR Description includes Resolves #<issue-number> or Fixes #<issue-number> this will automatically close the linked issue when the PR is merged and helps automate the maintainers workflow.

  3. Documentation: Update the relevant Generator documentation to accurately reflect the changes introduced in the PR, ensuring users and contributors have up-to-date guidance.

  4. Comments and JSDoc: Write clear and consistent JSDoc comments for functions, including parameter types, return values, and error conditions, so others can easily understand and use the code.

  5. DRY Code: Ensure the code follows the Don't Repeat Yourself principle. Look out for duplicate logic that can be reused.

  6. Test Coverage: Ensure the new code is well-tested with meaningful test cases that pass consistently and cover all relevant edge cases.

  7. Commit History: Contributors should avoid force-pushing as much as possible. It makes it harder to track incremental changes and review the latest updates.

  8. Template Design Principles Alignment: While reviewing template-related changes in the packages/ directory, ensure they align with the Assumptions and Principles. If any principle feels outdated or no longer applicable, start a discussion these principles are meant to evolve with the project.

  9. Reduce Scope When Needed: If an issue or PR feels too large or complex, consider splitting it and creating follow-up issues. Smaller, focused PRs are easier to review and merge.

  10. Bot Comments: As reviewers, check that contributors have appropriately addressed comments or suggestions made by automated bots. If there are bot comments the reviewer disagrees with, react to them or mark them as resolved, so the review history remains clear and accurate.

@coderabbitai
Copy link

coderabbitai bot commented Feb 9, 2026

📝 Walkthrough

Walkthrough

A new integration test file is added for the ConstructorSignature component in the Java Quarkus WebSocket template, providing test coverage across four query parameter scenarios (null, undefined, empty array, and populated values) using snapshot-based verification.

Changes

Cohort / File(s) Summary
ConstructorSignature Component Tests
packages/templates/clients/websocket/java/quarkus/test/components/ConstructorSignature.test.js
New integration test suite with AsyncAPI parser setup, fixture loading, and four test scenarios validating component rendering under different queryParams conditions via snapshot comparison.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows Conventional Commits format with 'test:' prefix and uses imperative mood to clearly describe adding test coverage for ConstructorSignature component.
Linked Issues check ✅ Passed The PR successfully adds comprehensive integration tests for ConstructorSignature component with multiple test scenarios covering null, undefined, empty array, and populated queryParams cases, achieving 100% code coverage.
Out of Scope Changes check ✅ Passed The changes are entirely focused on adding test coverage for ConstructorSignature component as specified in issue #1930, with no unrelated modifications present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
packages/templates/clients/websocket/java/quarkus/test/components/ConstructorSignature.test.js (2)

11-21: parsedAsyncAPIDocument is assigned but never used after Line 18.

Only channels is needed. You can simplify the setup:

♻️ Suggested cleanup
-  let parsedAsyncAPIDocument;
   let channels;
   let queryParamsArray;

   beforeAll(async () => {
     const parseResult = await fromFile(parser, asyncapiFilePath).parse();
-    parsedAsyncAPIDocument = parseResult.document;
-    channels = parsedAsyncAPIDocument.channels();
+    channels = parseResult.document.channels();

     const queryParams = getQueryParams(channels);
     queryParamsArray = queryParams ? Array.from(queryParams.entries()) : null;
   });

15-21: Consider adding a guard for parse failures in beforeAll.

If the fixture file is missing or the parse fails, parseResult.document will be null/undefined, and channels() will throw an unclear error. A simple assertion like expect(parseResult.document).toBeDefined() after parsing would surface the root cause faster. That said, this mirrors the existing pattern in Constructor.test.js, so it's not a blocker.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Adi-204 Adi-204 self-assigned this Feb 11, 2026
@Adi-204 Adi-204 moved this to In Progress in Maintainers work Feb 11, 2026
@sonarqubecloud
Copy link

@Adi-204
Copy link
Member

Adi-204 commented Feb 11, 2026

/rtm

@asyncapi-bot asyncapi-bot merged commit 19b03f9 into asyncapi:master Feb 11, 2026
16 of 18 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Maintainers work Feb 11, 2026
@Harsh16gupta Harsh16gupta deleted the test/ConstructorSignature-1930 branch February 11, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[TEST] Add component tests for ConstructorSignature.js (Java WebSocket Template)

3 participants