Skip to content

fix: upgrade simple-git to support Node 24+ #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
divyarathodgit wants to merge 2 commits into from
Closed

fix: upgrade simple-git to support Node 24+ #2005

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d76dafa
fix: upgrade simple-git to support Node 24+
ninadrathod Feb 16, 2026
3480ca9
Merge branch 'master' into fix/node-24-support
divyarathodgit Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/generator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"resolve-from": "^5.0.0",
"resolve-pkg": "^2.0.0",
"semver": "^7.3.2",
"simple-git": "^3.3.0",
"simple-git": "^3.30.0",
"ts-node": "^10.9.1",
"typescript": "^4.9.3"
},
Expand Down
37 changes: 18 additions & 19 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,8 @@
"apps/*",
"packages/**",
"!apps/generator/templates/bakedInTemplates/**"
]
}
],
"dependencies": {
"simple-git": "^3.30.0"
}
Comment on lines +49 to +51
Copy link

@coderabbitai coderabbitai bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# First, check if apps/generator/package.json declares simple-git
cat apps/generator/package.json | grep -A 10 -B 2 "simple-git"

Repository: asyncapi/generator

Length of output: 411

🏁 Script executed:

# Run the verification script to check if simple-git is used directly at root level (outside workspace packages)
rg -n "simple-git" --glob '!node_modules' --glob '!package-lock.json' --glob '!apps/**' --glob '!packages/**'

Repository: asyncapi/generator

Length of output: 105

🏁 Script executed:

# Check the root package.json to understand workspace configuration and current state
cat package.json | head -60

Repository: asyncapi/generator

Length of output: 2381

🏁 Script executed:

# Look for any root-level scripts or configurations that might use simple-git
rg -n "require.*simple-git|import.*simple-git" --glob '!node_modules' --glob '!apps/**' --glob '!packages/**'

Repository: asyncapi/generator

Length of output: 44

Remove unnecessary simple-git dependency from root package.json.

apps/generator/package.json already declares simple-git as its own dependency, and there is no usage of simple-git at the root level. Adding it to the root's dependencies is redundant in a workspace monorepo. Workspace packages should manage their own runtime dependencies independently. Remove this entry to keep the root manifest clean.

Suggested diff 
-  ],
-  "dependencies": {
-    "simple-git": "^3.30.0"
-  }
-}
+  ]
+}
🤖 Prompt for AI Agents 
In `@package.json` around lines 49 - 51, Remove the redundant "simple-git"
dependency from the root package.json by deleting the "simple-git": "^3.30.0"
entry from the "dependencies" object (ensure the JSON remains valid—remove the
trailing comma if needed or delete the whole empty "dependencies" block if
nothing else remains); keep runtime dependency management in
apps/generator/package.json which already declares simple-git.

}