feat: @asyncapi/react-componet upgraded to v2 together with react

[neoandmatrix]

Description

This PR introduces the changes to upgrade the @asyncapi/react-component to it's latest version 2.5.1. The extra added dependency react is to allow installation of newer react-dom as required by @asyncapi/react-component.

The tests are updated as well and are all passing.

Related issue(s)
Resolves #707

@derberg please review the PR and provide feedback.

Thanks.

[github-actions]

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[derberg]

lgtm, thanks a lot

[derberg]

@neoandmatrix please look into failing tests

[neoandmatrix]

@neoandmatrix please look into failing tests

Sure, will check and update.

Thanks.

[neoandmatrix]

Hey @derberg was working on the failing tests and after some debugging found the cause to be this method
at helpers/all.js in renderSpec function. The corresponding error Generator Error: window is not defined might be due to changes in newer version of react that might require browser functions or some dom functions. I was initially suspicious that this might be the as we are cause as we are using react-dom/server but just to confirm i tried using jsdom library to simulate the required browser functions as

and the generator worked as expected and correct output files were being generated. But this caused a new problem that after generating the template the generator is stuck and fails to exit only only exits upon using ctrl+c to manually exit it.

Can you please provide some feedback on if my approach is correct and if so then what might be probable cause of this being not exiting on itself. If some docs or material should be that i can refer please provide that will be much helpful for me.

Thanks.

[derberg]

@neoandmatrix you need to push your changes to PR so I can have a closer look

[neoandmatrix]

@neoandmatrix you need to push your changes to PR so I can have a closer look

@derberg Pushed the changes. Please review and provide feedback.
Thnaks.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[derberg]

I tried your changes on local, using npm run test:generator:v3 and your solution works, and cli terminates without issues.

also looks like tests are passing here too

[neoandmatrix]

I tried your changes on local, using npm run test:generator:v3 and your solution works, and cli terminates without issues.

also looks like tests are passing here too

Oh that's good then, looks like some older cache might be causing issue on my system then.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[derberg]

/rtm

[asyncapi-bot]

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[derberg]

@all-contributors please add @neoandmatrix for code

[allcontributors]

@derberg

I've put up a pull request to add @neoandmatrix! 🎉