fix: missing css and js files while singleFile=false#754
fix: missing css and js files while singleFile=false#754batchu5 wants to merge 2 commits intoasyncapi:masterfrom
Conversation
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
|
hi @batchu5 , i dont think this is the correct solution.. lets just wait for others to respond on the issue as few things needed to be clarified by the maintainers |
|
hi @lightning-sagar, I solved it as @Shurtu-gal mentioned in the issue that -p singleFile=false, so I just solved it based on that. |
|
@batchu5 i believe the goal of the issue, was when u run |



CSS and JS files are missing because in conditionalGeneration the value of the const should be false not "false"
in generator also there is bug in one line
const defaultValues = Object.keys(parameters || {}).filter(key => parameters[key].default);
should be changed to
const defaultValues = Object.keys(parameters || {}).filter(key => parameters[key].default !== undefined);
because just .default considers the false value as false and doesn't filter out!!
fixes #744