Skip to content

fix: missing css and js files while singleFile=false#754

Closed
batchu5 wants to merge 2 commits intoasyncapi:masterfrom
batchu5:fix-missing-css-and-js-files
Closed

fix: missing css and js files while singleFile=false#754
batchu5 wants to merge 2 commits intoasyncapi:masterfrom
batchu5:fix-missing-css-and-js-files

Conversation

@batchu5
Copy link
Contributor

@batchu5 batchu5 commented Nov 25, 2025

CSS and JS files are missing because in conditionalGeneration the value of the const should be false not "false"

in generator also there is bug in one line

const defaultValues = Object.keys(parameters || {}).filter(key => parameters[key].default);
should be changed to
const defaultValues = Object.keys(parameters || {}).filter(key => parameters[key].default !== undefined);

because just .default considers the false value as false and doesn't filter out!!
fixes #744

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarqubecloud
Copy link

@lightning-sagar
Copy link
Contributor

hi @batchu5 , i dont think this is the correct solution.. lets just wait for others to respond on the issue as few things needed to be clarified by the maintainers

@batchu5
Copy link
Contributor Author

batchu5 commented Nov 26, 2025

hi @lightning-sagar, I solved it as @Shurtu-gal mentioned in the issue that -p singleFile=false, so I just solved it based on that.
yup, let's see what maintainers say!!

@lightning-sagar
Copy link
Contributor

lightning-sagar commented Nov 26, 2025

@batchu5 i believe the goal of the issue, was when u run -p singleFile=false the js/css file is not being generated. i dont think it's generating the css/js

@batchu5 batchu5 closed this Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Missing CSS/JS when generating without singleFile

2 participants