Skip to content

fix: correct file path handling for PDF generation #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asyncapi-bot merged 4 commits into from
Dec 2, 2025
Merged

fix: correct file path handling for PDF generation #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8e9d8f
fix: correct file path handling for PDF generation
lightning-sagar Nov 26, 2025
56efa35
fix: use replaceAll for Windows path normalization in PDF generation
lightning-sagar Nov 26, 2025
b1ba362
fix: update the typeo
lightning-sagar Nov 29, 2025
54dba25
Merge branch 'master' into fix/file-path
derberg Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions hooks/99_generatePdf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ module.exports = {
try {
const browser = await puppeteer.launch({args: ['--no-sandbox', '--disable-setuid-sandbox']});
const page = await browser.newPage();

const fullPath = path.resolve(targetDir, 'index.html');
const fileUrl = `file:///${fullPath.replaceAll('\\', '/')}`;
// Go to prepared page with documentation
await page.goto(`file://${path.join(targetDir, 'index.html')}`, { waitUntil: 'networkidle0' });
await page.goto(fileUrl, { waitUntil: 'networkidle0' });

// Hide burger-menu in pdf
await page.evaluate(() => { document.querySelector('.burger-menu').style.display = 'none'; });
Expand Down
2 changes: 1 addition & 1 deletion scripts/transpile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ async function transpileTemplate() {
console.log("Output directory for transpiled files:", outputDir);
await transpileFiles(templateContentDir, outputDir, { recursive: true });
} catch (error) {
console.log("Error during template transpilation:", err)
console.log("Error during template transpilation:", error)
}
}

Expand Down