Skip to content

fix: render server host without scheme for AsyncAPI v3 #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sahillllllllll-bit wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: render server host without scheme for AsyncAPI v3 #659

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16d94ab
fix: render server host without scheme for AsyncAPI v3
sahillllllllll-bit Jan 21, 2026
aae278a
fix(sonar): correct PropTypes syntax for ServerInfo
sahillllllllll-bit Jan 21, 2026
2700b1b
chore: remove PropTypes validation as per review feedback
sahillllllllll-bit Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/Servers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function ServerInfo({ server }) {
return (
<Text>
<Text>
<ListItem>URL: `{server.url()}`</ListItem>
<ListItem>Host: `{server.host()}${server.pathname() ? server.pathname() : ''}`</ListItem>
<ListItem>Protocol: `{server.protocol()}{server.protocolVersion() ? ` ${server.protocolVersion()}` : ''}`</ListItem>
</Text>
{server.hasDescription() && (
Expand All @@ -63,6 +63,7 @@ function ServerInfo({ server }) {
);
}


const variableHeader = ['Name', 'Description', 'Default value', 'Allowed values'];
const variableRenderer = (variable) => [
variable.id() || '-',
Expand Down