feat: add attrs support to Python preset#2183
Merged
jonaslagoni merged 6 commits intoasyncapi:masterfrom Mar 13, 2025
Merged
Conversation
Manancode
requested review from
asyncapi-bot-eve,
jonaslagoni,
kennethaasan and
magicmatatjahu
as code owners
✅ Deploy Preview for modelina canceled.
|
jonaslagoni
changed the title
jonaslagoni
requested changes
Feb 17, 2025
Member
jonaslagoni
left a comment
jonaslagoni
left a comment
There was a problem hiding this comment.
Just the tests that is missing ✌️
Contributor
Author
Sure sir will add that too |
Contributor
Author
|
@jonaslagoni added the tests for both presets. Fixes issue |
Pull Request Test Coverage Report for Build 13822831335Details
💛 - Coveralls |
jonaslagoni
requested changes
Mar 3, 2025
Member
There was a problem hiding this comment.
@Manancode make sure you do a self-review 🙂 You need to fix some linting 🙂
|
jonaslagoni
approved these changes
Mar 13, 2025
Member
|
@all-contributors please add @Manancode for code, test |
Contributor
|
I've put up a pull request to add @Manancode! 🎉 |
Member
|
@Manancode I would highly recommend you make another PR that changes the docs so people can know about your new presets 🙂 |
Contributor
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds attrs support to Python preset by using @attr.s(auto_attribs=True).
Ensures proper class serialization using attrs.