fix: deserialization in pydantic#2311
Merged
jonaslagoni merged 1 commit intoasyncapi:masterfrom Jul 26, 2025
Merged
Conversation
when doing deserialization in pydantic only unknown properties must be added to additional_properties
412b
requested review from
asyncapi-bot-eve,
jonaslagoni,
kennethaasan and
magicmatatjahu
as code owners
✅ Deploy Preview for modelina canceled.
|
|
Pull Request Test Coverage Report for Build 16496805573Details
💛 - Coveralls |
Contributor
Author
|
@jonaslagoni can you please take a look at this one, when you have time? |
Contributor
|
🎉 This PR is included in version 5.3.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when doing deserialization in pydantic only unknown properties must be added to additional_properties
Description
current generated code contains a bug, which leads to matched fields appearing in
additional_properties.the fix is pretty trivial and straight-forward: we only process unknown properties.
Related Issue
it seemed to not worth creating one for such a trivial fix.
Checklist
npm run lint).npm run test).Additional Notes