Skip to content

fix: typescript date mapping #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonaslagoni merged 6 commits into from
Dec 16, 2025
Merged

fix: typescript date mapping #2393

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26dc626
feat: map string formats (date-time, date, time) to Date in TypeScrip…
AarishMansur Dec 12, 2025
cbca257
Merge branch 'master' into fix/typescript-date-mapping
AarishMansur Dec 12, 2025
7fea54f
Merge branch 'next' into fix/typescript-date-mapping
jonaslagoni Dec 15, 2025
5078959
feat(runtime): map date formats to Date and verify TS marshalling
AarishMansur Dec 16, 2025
c1efdae
test: update snapshots for Date type mapping
AarishMansur Dec 16, 2025
4e51272
docs(migration): document TypeScript Date mapping
AarishMansur Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"dependencies": {
"@apidevtools/json-schema-ref-parser": "^11.1.0",
"@apidevtools/swagger-parser": "^10.1.0",
"@asyncapi/modelina": "^5.10.1",
"@asyncapi/multi-parser": "^2.2.0",
"@asyncapi/parser": "^3.4.0",
"alterschema": "^1.1.2",
Expand Down
4 changes: 4 additions & 0 deletions src/generators/typescript/TypeScriptConstrainer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ export const TypeScriptDefaultTypeMapping: TypeScriptTypeMapping = {
return applyNullable(constrainedModel, 'number');
},
String({ constrainedModel }): string {
const format = constrainedModel?.options?.format;
if(format ==="date-time" || format ==="date"|| format ==='time'){
return applyNullable(constrainedModel, 'Date');
}
return applyNullable(constrainedModel, 'string');
},
Boolean({ constrainedModel }): string {
Expand Down
24 changes: 12 additions & 12 deletions test/generators/typescript/__snapshots__/TypeScriptGenerator.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,15 @@ Array [
private _specversion: string;
private _reservedType: CloudEventType.DOG = CloudEventType.DOG;
private _dataschema?: string;
private _time?: string;
private _time?: Date;
private _additionalProperties?: Map<string, any>;

constructor(input: {
id: string,
source: string,
specversion: string,
dataschema?: string,
time?: string,
time?: Date,
additionalProperties?: Map<string, any>,
}) {
this._id = input.id;
Expand All @@ -130,8 +130,8 @@ Array [
get dataschema(): string | undefined { return this._dataschema; }
set dataschema(dataschema: string | undefined) { this._dataschema = dataschema; }

get time(): string | undefined { return this._time; }
set time(time: string | undefined) { this._time = time; }
get time(): Date | undefined { return this._time; }
set time(time: Date | undefined) { this._time = time; }

get additionalProperties(): Map<string, any> | undefined { return this._additionalProperties; }
set additionalProperties(additionalProperties: Map<string, any> | undefined) { this._additionalProperties = additionalProperties; }
Expand All @@ -146,15 +146,15 @@ Array [
private _specversion: string;
private _reservedType: CloudEventType.CAT = CloudEventType.CAT;
private _dataschema?: string;
private _time?: string;
private _time?: Date;
private _additionalProperties?: Map<string, any>;

constructor(input: {
id: string,
source: string,
specversion: string,
dataschema?: string,
time?: string,
time?: Date,
additionalProperties?: Map<string, any>,
}) {
this._id = input.id;
Expand All @@ -179,8 +179,8 @@ Array [
get dataschema(): string | undefined { return this._dataschema; }
set dataschema(dataschema: string | undefined) { this._dataschema = dataschema; }

get time(): string | undefined { return this._time; }
set time(time: string | undefined) { this._time = time; }
get time(): Date | undefined { return this._time; }
set time(time: Date | undefined) { this._time = time; }

get additionalProperties(): Map<string, any> | undefined { return this._additionalProperties; }
set additionalProperties(additionalProperties: Map<string, any> | undefined) { this._additionalProperties = additionalProperties; }
Expand Down Expand Up @@ -377,13 +377,13 @@ Array [
"class ReservedEvent {
private _id: string;
private _action?: Action;
private _eventTime?: string;
private _eventTime?: Date;
private _additionalProperties?: Map<string, any>;

constructor(input: {
id: string,
action?: Action,
eventTime?: string,
eventTime?: Date,
additionalProperties?: Map<string, any>,
}) {
this._id = input.id;
Expand All @@ -398,8 +398,8 @@ Array [
get action(): Action | undefined { return this._action; }
set action(action: Action | undefined) { this._action = action; }

get eventTime(): string | undefined { return this._eventTime; }
set eventTime(eventTime: string | undefined) { this._eventTime = eventTime; }
get eventTime(): Date | undefined { return this._eventTime; }
set eventTime(eventTime: Date | undefined) { this._eventTime = eventTime; }

get additionalProperties(): Map<string, any> | undefined { return this._additionalProperties; }
set additionalProperties(additionalProperties: Map<string, any> | undefined) { this._additionalProperties = additionalProperties; }
Expand Down