feat: generate exported constants for properties with const values#2403
Open
Shyam-Raghuwanshi wants to merge 8 commits intoasyncapi:masterfrom
Open
Conversation
❌ Deploy Preview for modelina failed.
|
|
jonaslagoni
requested changes
Feb 8, 2026
Member
jonaslagoni
left a comment
jonaslagoni
left a comment
There was a problem hiding this comment.
Needs test and docs. Also got a few sonar cloud issues
jonaslagoni
requested changes
Feb 8, 2026
Member
jonaslagoni
left a comment
jonaslagoni
left a comment
There was a problem hiding this comment.
Yea, I dont think this is the right approach.
If we really want to export const values we need to use the same approach as for enums and create separate renderer for this.
test/generators/typescript/__snapshots__/TypeScriptGenerator.spec.ts.snap
Show resolved
Hide resolved
Shyam-Raghuwanshi
requested review from
asyncapi-bot-eve,
kennethaasan and
magicmatatjahu
as code owners
Shyam-Raghuwanshi
force-pushed
the
feature/generate-exported-constants-for-const-properties
branch
from
11995f4 to
c9dff41
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2399
Checklist
npm run lint).npm run test).Additional Notes