Skip to content

fix: json tag formatting for Go#2431

Merged
jonaslagoni merged 2 commits intoasyncapi:masterfrom
AndersBennedsgaard:fix/go-json-tag
Feb 8, 2026
Merged

fix: json tag formatting for Go#2431
jonaslagoni merged 2 commits intoasyncapi:masterfrom
AndersBennedsgaard:fix/go-json-tag

Conversation

@AndersBennedsgaard
Copy link
Contributor

@AndersBennedsgaard AndersBennedsgaard commented Feb 5, 2026

Description

Adds end quote to Go generator JSON struct tag

Related Issue

#2430

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

I have not added tests or documentation as I am unsure what should be done for such a small change

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@netlify
Copy link

netlify bot commented Feb 5, 2026

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit aa32931
🔍 Latest deploy log https://app.netlify.com/projects/modelina/deploys/698880fff74d050008593950

@AndersBennedsgaard
Copy link
Contributor Author

We require all PRs to follow Conventional Commits specification. More details 👇🏼

 The subject "JSON tag formatting in CommonPreset.ts" found in the pull request title "fix(go generator): JSON tag formatting in CommonPreset.ts" should start with a lowercase character.

I have fixed this with a new commit, so this should not be true any more

@jonaslagoni jonaslagoni changed the title fix(go generator): JSON tag formatting in CommonPreset.ts fix: JSON tag formatting for Go Feb 8, 2026
@jonaslagoni jonaslagoni changed the title fix: JSON tag formatting for Go fix: json tag formatting for Go Feb 8, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2026

@coveralls
Copy link

coveralls commented Feb 8, 2026

Pull Request Test Coverage Report for Build 21798133013

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.997%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/generators/go/presets/CommonPreset.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 21775753379: 0.0%
Covered Lines: 6942
Relevant Lines: 7421

💛 - Coveralls

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually surprised it did not require test update 🤨

@jonaslagoni jonaslagoni merged commit 8c5e495 into asyncapi:master Feb 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants