fix: trigger custom schema on messages only defined in a channel of an operation#1100
fix: trigger custom schema on messages only defined in a channel of an operation#1100liam-oldershaw-ctct wants to merge 2 commits intoasyncapi:masterfrom
Conversation
|
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
fmvilas
left a comment
There was a problem hiding this comment.
That's a great catch. Appreciate the fix 🙏 Would you mind adding tests to cover this so it won't happen again by mistake?
… only definined in an operations channel
|
|
@fmvilas while writing the unit test I've noticed that the schema also doesn't get an anonymous id like the tests above.. So that might be another issue (not sure how important though) |
You probably caught another issue, yeah. Would you mind adding a separate PR for that? I think a small and focused PR is always better. |
|
Edit: Ahh, i see the issue around updating the repo maintainers. Apologies, All good |
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |



Description
Related issue(s)
Resolves: #1099