fix: validate channel address when parameters are defined#1123
Open
abhi-03-kh wants to merge 3 commits intoasyncapi:masterfrom
Open
fix: validate channel address when parameters are defined#1123abhi-03-kh wants to merge 3 commits intoasyncapi:masterfrom
abhi-03-kh wants to merge 3 commits intoasyncapi:masterfrom
Conversation
abhi-03-kh
requested review from
asyncapi-bot-eve,
fmvilas and
magicmatatjahu
as code owners
🦋 Changeset detectedLatest commit: e0fd14a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Author
|
@fmvilas @magicmatatjahu , any feedback on this when you have time? |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a validation rule to ensure that if a Channel Object has
parametersdefined, theaddressfield must not be null.Fixes #875
Changes
channel-parameters-require-addressrule tov3/ruleset.ts.channel-parameters.spec.tsto verify the rule catches invalid documents.Verification
npm test -- test/ruleset/rules/v3/channel-parameters.spec.ts