Skip to content

ci: add action to sync v3 spec-json-schema updates with website#562

Closed
AceTheCreator wants to merge 39 commits intoasyncapi:masterfrom
AceTheCreator:automate-spec-update-to-website
Closed

ci: add action to sync v3 spec-json-schema updates with website#562
AceTheCreator wants to merge 39 commits intoasyncapi:masterfrom
AceTheCreator:automate-spec-update-to-website

Conversation

@AceTheCreator
Copy link
Member

With the integration of the Schyma package, we can now visualize the spec-json-schema file on the AsyncAPI specification explorer for educational purposes. This action ensures that the website automatically receives updated changes whenever the v3 JSON schema file in this repository is modified.

cc @derberg


- name: Copy version 3 Schema File
run: |
cp -r schemas/3.0.0-without-\$id.json website/config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you copying recursively here? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I'll get rid of it, i was using it when i was exploring copying other versions too, which i found wasn't neccessary for this particular usecase.

@sonarqubecloud
Copy link

@AceTheCreator
Copy link
Member Author

@fmvilas, removed the -r flag

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but you have comments from Lukasz to address so I'll wait to approve.

@derberg
Copy link
Member

derberg commented Mar 25, 2025

why you have some changes in schemas/3.0.0-without-$id.json in this PR

@AceTheCreator
Copy link
Member Author

AceTheCreator commented Mar 25, 2025

why you have some changes in schemas/3.0.0-without-$id.json in this PR

It will be reverted, just to test the job to ensure it still works as expected

derberg
derberg previously approved these changes Mar 25, 2025
@sonarqubecloud
Copy link

@AceTheCreator
Copy link
Member Author

Closing PR, opened a new one #575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments