fix: remove invalid x- fields from Kafka bindings example#1170
Open
wei123-web wants to merge 1 commit intoasyncapi:masterfrom
Open
fix: remove invalid x- fields from Kafka bindings example#1170wei123-web wants to merge 1 commit intoasyncapi:masterfrom
wei123-web wants to merge 1 commit intoasyncapi:masterfrom
Conversation
wei123-web
requested review from
GreenRover,
asyncapi-bot-eve,
char0n,
dalelane,
derberg and
fmvilas
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Author
|
Hello! AsyncAPI maintainers This PR fixes the ADEO Kafka example by removing invalid Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title: ""
---fix: remove invalid x- fields from Kafka bindings example
Related issue(s):
The ADEO Kafka example had invalid x- fields in Kafka bindings.
These fields are not allowed according to the Kafka binding JSON schema.
Removed x-key.subject.name.strategy and x-value.subject.name.strategy.
Related issue(s): #1164