Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use changesets to manage release #706

Merged
merged 35 commits into from
Jul 7, 2023

Conversation

KhudaDad414
Copy link
Member

@KhudaDad414 KhudaDad414 commented Jun 27, 2023

Description
Before merging we should make sure that all of the following things are done:

  • setup tags so the release process can pick em up.
  • disable version bump workflow.
  • check if there are any changes needs to be made as a result of not following semantic release.
  • disable Conventional Commits workflow for PR titles.

Related Issues
Fixes #628
Fixes #696
Fixes #651
Related to #723
Testing
Github Release: https://github.com/KhudaDad414/studio/

@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 5774a70
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/64a7ce713b351500081d4536
😎 Deploy Preview https://deploy-preview-706--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 5774a70
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/64a7ce71fd5692000848a70e
😎 Deploy Preview https://deploy-preview-706--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

apps/studio/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@KhudaDad414 KhudaDad414 changed the title chore: fix release process to release a single version chore: [ADR-002] use changesets to manage release Jul 4, 2023
@KhudaDad414 KhudaDad414 closed this Jul 4, 2023
@KhudaDad414 KhudaDad414 force-pushed the master branch 2 times, most recently from ad46fe4 to f8597be Compare July 4, 2023 10:52
@KhudaDad414 KhudaDad414 reopened this Jul 4, 2023
@KhudaDad414 KhudaDad414 marked this pull request as draft July 4, 2023 10:59
@KhudaDad414 KhudaDad414 marked this pull request as ready for review July 4, 2023 16:04
@KhudaDad414
Copy link
Member Author

@fmvilas @Amzani would love to know what you think.

@KhudaDad414 KhudaDad414 requested a review from fmvilas July 4, 2023 16:10
@KhudaDad414 KhudaDad414 changed the title chore: [ADR-002] use changesets to manage release chore: use changesets to manage release Jul 5, 2023
fmvilas
fmvilas previously approved these changes Jul 5, 2023
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@KhudaDad414
Copy link
Member Author

@fmvilas checks pass now. another review. 🙇

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@KhudaDad414
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 7f2463d into asyncapi:master Jul 7, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants