Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
anshgoyalevil authored Mar 19, 2024
1 parent d1a270c commit 1e61a1c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
5 changes: 2 additions & 3 deletions components/community/Card.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import IconArrowUp from '../icons/ArrowUp';
import Heading from '../typography/Heading';
import Paragraph from '../typography/Paragraph';

interface SmallHomeCardProp {
interface CardProps {
icon: string;
tagline: string;
taglineBg: string;
Expand All @@ -24,7 +24,6 @@ interface SmallHomeCardProp {

/**
* @description This component displays Small Home Card.
* @param {SmallHomeCardProp} props - The props for Small Home Card component.
* @param {string} props.icon - The icon for the card.
* @param {string} props.tagline - The tagline for the card.
* @param {string} props.taglineBg - The background color for the tagline.
Expand All @@ -47,7 +46,7 @@ export default function Card({
btnText,
btnBg,
link
}: SmallHomeCardProp) {
}: CardProps) {
if (type === CardType.SMALL) {
return (
<Link href={link} target={link.includes('http') ? '_blank' : undefined}>
Expand Down
6 changes: 3 additions & 3 deletions components/community/HomeCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { HeadingLevel, HeadingTypeStyle } from '@/types/typography/Heading';
import Button from '../buttons/Button';
import Heading from '../typography/Heading';

interface HomeCardProp {
interface HomeCardProps {
headline: string;
title: string;
description: string;
Expand All @@ -17,7 +17,7 @@ interface HomeCardProp {

/**
* @description This component displays Home Card.
* @param {HomeCardProp} props - The props for Home Card component.
* @param {HomeCardProps} props - The props for Home Card component.
* @param {string} props.headline - The headline for the home card.
* @param {string} props.title - The title for the home card.
* @param {string} props.description - The description for the home card.
Expand All @@ -32,7 +32,7 @@ export default function HomeCards({
btnText,
link,
className
} : HomeCardProp) {
} : HomeCardProps) {
return (
<div className='z-40 mt-20 w-full rounded-lg bg-white shadow-xl md:flex md:h-130 md:justify-between'>
<div className='flex h-auto w-full flex-col justify-between p-10 text-center md:w-2/5 md:text-left'>
Expand Down

0 comments on commit 1e61a1c

Please sign in to comment.