fix: improve visibility of newsletter input fields in dark mode #5128#5128
fix: improve visibility of newsletter input fields in dark mode #5128#5128Dsp023 wants to merge 4 commits intoasyncapi:masterfrom
Conversation
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5128--asyncapi-website.netlify.app/ |
📝 WalkthroughWalkthroughAdds optional dark-mode theming to the InputBox component via a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@components/InputBox.tsx`:
- Line 14: Remove the trailing comma in the props destructuring so the last
defaulted prop (dark = false) is not followed by a comma; locate the InputBox
component's parameter list (the destructured props where "dark = false,"
appears) and change it to "dark = false" (no trailing comma) to satisfy
Prettier/comma-dangle rules.
🧹 Nitpick comments (1)
components/InputBox.tsx (1)
23-27: Dark mode styling looks good overall; consider addingbg-transparentor explicit light background for symmetry.The dark branch sets
bg-zinc-900, but the light branch doesn't explicitly set a background. If the input inherits a dark parent background in some other context, the light variant could appear broken. A minor concern — only relevant ifInputBoxis ever reused outsideNewsletterSubscribe.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5128 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 796 796
Branches 146 146
=========================================
Hits 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please mention issue number . |



Refactor InputBox component to support a dark mode prop. Apply high-contrast styles (border, placeholder, focus) when the dark prop is active to ensure the newsletter input fields are clearly visible on dark backgrounds.
Summary by CodeRabbit