Skip to content

fix: improve visibility of newsletter input fields in dark mode #5128#5128

Open
Dsp023 wants to merge 4 commits intoasyncapi:masterfrom
Dsp023:fix/newsletter-visibility
Open

fix: improve visibility of newsletter input fields in dark mode #5128#5128
Dsp023 wants to merge 4 commits intoasyncapi:masterfrom
Dsp023:fix/newsletter-visibility

Conversation

@Dsp023
Copy link

@Dsp023 Dsp023 commented Feb 10, 2026

Refactor InputBox component to support a dark mode prop. Apply high-contrast styles (border, placeholder, focus) when the dark prop is active to ensure the newsletter input fields are clearly visible on dark backgrounds.

Summary by CodeRabbit

  • New Features
    • Added dark mode support for input fields and the newsletter subscription form so inputs automatically adapt styling when the app is in dark theme, improving visual consistency across light/dark modes.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@netlify
Copy link

netlify bot commented Feb 10, 2026

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5297dfb
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/698b2f76a3d9d70008ef8f86
😎 Deploy Preview https://deploy-preview-5128--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Feb 10, 2026

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 37
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-5128--asyncapi-website.netlify.app/

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

Adds optional dark-mode theming to the InputBox component via a new dark?: boolean prop (default false) and propagates that prop from NewsletterSubscribe to its InputBox instances; updates the InputBoxProps type accordingly.

Changes

Cohort / File(s) Summary
InputBox component & props type
components/InputBox.tsx, types/components/InputBoxPropsType.ts
Added optional dark?: boolean to InputBoxProps. InputBox now accepts dark = false and conditionally applies dark or light CSS classes to the input element.
Newsletter form propagation
components/NewsletterSubscribe.tsx
Propagated dark={dark} to the name and email InputBox instances so their styling follows the parent dark flag.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I found a toggle, soft and sly,
Inputs dressed in midnight sky,
I nibble lines of CSS bright,
Hopping through shadowed light,
Happy code — both dark and spry. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check ✅ Passed The title accurately summarizes the main change: improving visibility of newsletter input fields in dark mode by adding dark mode styling support.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@components/InputBox.tsx`:
- Line 14: Remove the trailing comma in the props destructuring so the last
defaulted prop (dark = false) is not followed by a comma; locate the InputBox
component's parameter list (the destructured props where "dark = false,"
appears) and change it to "dark = false" (no trailing comma) to satisfy
Prettier/comma-dangle rules.
🧹 Nitpick comments (1)
components/InputBox.tsx (1)

23-27: Dark mode styling looks good overall; consider adding bg-transparent or explicit light background for symmetry.

The dark branch sets bg-zinc-900, but the light branch doesn't explicitly set a background. If the input inherits a dark parent background in some other context, the light variant could appear broken. A minor concern — only relevant if InputBox is ever reused outside NewsletterSubscribe.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7653853) to head (5297dfb).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #5128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          796       796           
  Branches       146       146           
=========================================
  Hits           796       796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SHUBHANSHU602
Copy link

Please mention issue number .

@Dsp023 Dsp023 changed the title fix: improve visibility of newsletter input fields in dark mode fix: improve visibility of newsletter input fields in dark mode #5128 Feb 14, 2026
@Dsp023 Dsp023 changed the title fix: improve visibility of newsletter input fields in dark mode #5128 [ #5128 ]fix: improve visibility of newsletter input fields in dark mode Feb 14, 2026
@Dsp023 Dsp023 changed the title [ #5128 ]fix: improve visibility of newsletter input fields in dark mode fix: improve visibility of newsletter input fields in dark mode #5128 Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Be Triaged

Development

Successfully merging this pull request may close these issues.

3 participants