Skip to content

fix: improve visibility of newsletter input fields in dark mode #5128 #5128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dsp023 wants to merge 4 commits into
base: master
Choose a base branch
from
+18 −2
Open

fix: improve visibility of newsletter input fields in dark mode #5128 #5128

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
059f00c
fix: improve visibility of newsletter input fields in dark mode
Dsp023 Feb 10, 2026
bc348d0
fix: resolve linting errors in InputBox
Dsp023 Feb 10, 2026
5cd28dd
fix: resolve additional linting errors in modified files
Dsp023 Feb 10, 2026
5297dfb
fix: enforce strict prettier formatting to match project rules
Dsp023 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions components/InputBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,26 @@ import type { InputBoxProps } from '@/types/components/InputBoxPropsType';
/**
* This component renders input box.
*/
export default function InputBox({ inputType, inputName, placeholder, inputValue, setInput }: InputBoxProps) {
export default function InputBox({
inputType,
inputName,
placeholder,
inputValue,
setInput,
dark = false,
}: InputBoxProps) {
return (
<input
type={inputType}
name={inputName}
placeholder={placeholder}
value={inputValue}
onChange={(e) => setInput(e.target.value)}
className='form-input mt-2 block w-full rounded-md sm:text-sm sm:leading-5 md:mt-0 md:flex-1'
className={`form-input mt-2 block w-full rounded-md sm:text-sm sm:leading-5 md:mt-0 md:flex-1 ${
dark
? 'border-zinc-700 bg-zinc-900 text-white placeholder-zinc-500 focus:border-indigo-500 focus:ring-indigo-500'
: 'border-gray-300 text-gray-900'
}`}
required
data-testid={`NewsletterSubscribe-${inputType}-input`}
/>
Expand Down
2 changes: 2 additions & 0 deletions components/NewsletterSubscribe.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,13 +137,15 @@ export default function NewsletterSubscribe({
placeholder={ready ? t('nameInput') : 'Your name'}
inputValue={name}
setInput={setName}
dark={dark}
/>
<InputBox
inputType={InputTypes.EMAIL}
inputName='email'
placeholder={ready ? t('emailInput') : 'Your email'}
inputValue={email}
setInput={setEmail}
dark={dark}
/>
<Button
type={ButtonType.SUBMIT}
Expand Down
3 changes: 3 additions & 0 deletions types/components/InputBoxPropsType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@ export interface InputBoxProps {

/** The function to set value of the input. */
setInput: (value: string) => void;

/** If true, the theme of the component will be dark. */
dark?: boolean;
}
Loading