feat: migrate tools components to typescript #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devilkiller-ag
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
devilkiller-ag
commented
Mar 18, 2024
akshatnema
requested changes
Mar 23, 2024
components/tools/Tags.tsx
Outdated
| }; | ||
|
|
||
| /** | ||
| * @description This component displays tags. |
There was a problem hiding this comment.
Describe these tags more, on where it is used.
components/tools/ToolsCard.tsx
Outdated
Comment on lines
30
to
39
| useEffect(() => { | ||
| const divHeight = descriptionRef.current?.offsetHeight || 0; | ||
| const numberOfLines = divHeight / 20; | ||
|
|
||
| if (numberOfLines > 3) { | ||
| setShowMoreDescription(true); | ||
| } else { | ||
| setShowMoreDescription(false); | ||
| }; | ||
| }, []); |
components/tools/ToolsList.tsx
Outdated
Comment on lines
30
to
39
| </Paragraph> | ||
| <hr className='my-8' /> | ||
| <div className='flex grid-cols-3 flex-col gap-8 lg:grid'> | ||
| {toolsListData[categoryName].toolsList.map((tool, toolIndex) => ( | ||
| <ToolsCard key={toolIndex} toolData={tool} /> | ||
| ))} | ||
| </div> | ||
| </div> | ||
| ); | ||
|
|
There was a problem hiding this comment.
Suggested change
| </Paragraph> | |
| <hr className='my-8' /> | |
| <div className='flex grid-cols-3 flex-col gap-8 lg:grid'> | |
| {toolsListData[categoryName].toolsList.map((tool, toolIndex) => ( | |
| <ToolsCard key={toolIndex} toolData={tool} /> | |
| ))} | |
| </div> | |
| </div> | |
| ); | |
| </Paragraph> | |
| <hr className='my-8' /> | |
| <div className='flex grid-cols-3 flex-col gap-8 lg:grid'> | |
| {toolsListData[categoryName].toolsList.map((tool, toolIndex) => ( | |
| <ToolsCard key={toolIndex} toolData={tool} /> | |
| ))} | |
| </div> | |
| </div> | |
| ); |
There was a problem hiding this comment.
Hi, I can't understand, what to change here. The indentation is already correct. Can you please elaborate a little on this?
scripts/tools/categorylist.ts
Outdated
There was a problem hiding this comment.
Don't migrate this file to typescript. These files are part of scripts and we aren't migrating scripts folder yet.
akshatnema
reviewed
Mar 27, 2024
scripts/tools/categorylist.js
Outdated
There was a problem hiding this comment.
Is it necessary to make these changes?
There was a problem hiding this comment.
Nope, I have restored the original content.
akshatnema
approved these changes
Mar 29, 2024
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the components inside the following folder to TypeScript:
Related issue(s)
#2636