fix: remove console logs exposing user data and critical website flows #3845

sagarkori143 · 2025-03-08T16:24:38Z

This PR removes unnecessary console logs that were exposing user data and critical website flows in the browser console. Keeping these logs could lead to potential security risks and unintended data exposure.

Summary by CodeRabbit

Chores
- Removed unnecessary logging from the newsletter subscription and discussion handling processes to streamline user experience.

coderabbitai · 2025-03-08T16:24:46Z

Walkthrough

This pull request removes unnecessary console logging from two parts of the codebase. In the NewsletterSubscribe component, logging and ESLint disable comments in the handleSubmit function have been deleted. Similarly, a console log in the markAnswer function of the discussion background processing file has been removed. The changes do not affect the core control flow, error handling, or any public API declarations.

Changes

File Path	Change Summary
`components/NewsletterSubscribe.tsx`	Removed console logging and ESLint disable comments in the `handleSubmit` function.
`netlify/functions/.../Reposity.ts`	Removed a console log statement from the `markAnswer` function.

Poem

I'm a happy rabbit with a coding spree,
Leaping over logs in pure harmony,
Debug prints vanished, quiet as the night,
Code now gleams with a cleaner light,
Hopping into a future bright! 🐰✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e7598a and e2500a8.

📒 Files selected for processing (1)

components/NewsletterSubscribe.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

components/NewsletterSubscribe.tsx

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-03-08T16:24:54Z

✅ Deploy Preview for asyncapi-website ready!

Name	Link
🔨 Latest commit	`b6bf03c`
🔍 Latest deploy log	https://app.netlify.com/projects/asyncapi-website/deploys/6831ad5061f7480008455595
😎 Deploy Preview	https://deploy-preview-3845--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

sambhavgupta0705 · 2025-04-06T10:23:42Z

@sagarkori143 checks are failing

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fdbfe0 and ab56b99.

📒 Files selected for processing (1)

components/NewsletterSubscribe.tsx (1 hunks)

🧰 Additional context used

🪛 ESLint

components/NewsletterSubscribe.tsx

[error] 88-88: Expected blank line before this statement.

(padding-line-between-statements)

🪛 GitHub Actions: PR testing - if Node project

components/NewsletterSubscribe.tsx

[error] 88-88: Expected blank line before this statement. padding-line-between-statements

components/NewsletterSubscribe.tsx

coderabbitai

Actionable comments posted: 1

♻️ Duplicate comments (1)

components/NewsletterSubscribe.tsx (1)

82-90: Good security practice: Removing console logs of user data.

I see you've removed the console log that was exposing response data (which likely contained user details) after the fetch call, which aligns with the PR's objective to remove unnecessary console logs that expose user data. This is a good security practice.

🧰 Tools

🪛 ESLint

[error] 88-88: Trailing spaces not allowed.

(no-trailing-spaces)

[error] 88-88: Delete ······

(prettier/prettier)

🪛 GitHub Actions: PR testing - if Node project

[error] 88-88: Trailing spaces not allowed. no-trailing-spaces

[error] 88-88: Delete ······ prettier/prettier

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab56b99 and 3e7598a.

📒 Files selected for processing (1)

components/NewsletterSubscribe.tsx (1 hunks)

🧰 Additional context used

🪛 ESLint

components/NewsletterSubscribe.tsx

[error] 88-88: Trailing spaces not allowed.

(no-trailing-spaces)

[error] 88-88: Delete ······

(prettier/prettier)

🪛 GitHub Actions: PR testing - if Node project

components/NewsletterSubscribe.tsx

[error] 88-88: Trailing spaces not allowed. no-trailing-spaces

[error] 88-88: Delete ······ prettier/prettier

⏰ Context from checks skipped due to timeout of 180000ms (2)

GitHub Check: Header rules - asyncapi-website
GitHub Check: Pages changed - asyncapi-website

components/NewsletterSubscribe.tsx

codecov · 2025-04-11T09:54:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (829bd73) to head (b6bf03c).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #3845   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          778       778           
  Branches       144       144           
=========================================
  Hits           778       778

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sagarkori143 · 2025-04-11T09:57:37Z

All issues have been resolved. PTAL!
@sambhavgupta0705

akshatnema · 2025-05-24T11:35:55Z

/rtm

asyncapi#3845) Co-authored-by: Sagar Kori <[email protected]> Co-authored-by: Chan <[email protected]> Co-authored-by: Sambhav Gupta <[email protected]> Co-authored-by: Akshat Nema <[email protected]>

console logs cleanup

17dc36c

sagarkori143 requested review from derberg, akshatnema, anshgoyalevil, Mayaleeeee and asyncapi-bot-eve as code owners March 8, 2025 16:24

asyncapi-bot and others added 3 commits March 8, 2025 17:24

Merge branch 'master' into console

6fdbfe0

revoked the changes done in the package files

9e62e1d

Merge branch 'console' of github.com:sagarkori143/website into console

05cee84

sagarkori143 changed the title ~~Remove console logs exposing user data and critical website flows~~ fix: Remove console logs exposing user data and critical website flows Mar 8, 2025

sagarkori143 changed the title ~~fix: Remove console logs exposing user data and critical website flows~~ fix: remove console logs exposing user data and critical website flows Mar 8, 2025

Merge branch 'master' into console

55ce163

sagarkori143 requested a review from sambhavgupta0705 as a code owner March 21, 2025 11:51

sagarkori143 added 2 commits April 11, 2025 00:27

Merge branch 'master' into console

fa5a980

merge

a2185bf

asyncapi-bot requested review from devilkiller-ag and vishvamsinh28 April 10, 2025 19:05

sagarkori143 added 2 commits April 11, 2025 14:55

missing semicolon

8fbb833

linting

ab56b99

coderabbitai bot reviewed Apr 11, 2025

View reviewed changes

components/NewsletterSubscribe.tsx Outdated Show resolved Hide resolved

linting

3e7598a

coderabbitai bot reviewed Apr 11, 2025

View reviewed changes

components/NewsletterSubscribe.tsx Outdated Show resolved Hide resolved

linting

e2500a8

Merge branch 'master' into console

2d2c228

akshatnema approved these changes May 24, 2025

View reviewed changes

Merge branch 'master' into console

b6bf03c

asyncapi-bot added the ready-to-merge label May 24, 2025

asyncapi-bot merged commit 76a0983 into asyncapi:master May 24, 2025
18 of 19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: remove console logs exposing user data and critical website flows #3845

fix: remove console logs exposing user data and critical website flows #3845

Uh oh!

sagarkori143 commented Mar 8, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 8, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

netlify bot commented Mar 8, 2025 •

edited

Loading

Uh oh!

sambhavgupta0705 commented Apr 6, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

codecov bot commented Apr 11, 2025 •

edited

Loading

Uh oh!

sagarkori143 commented Apr 11, 2025

Uh oh!

akshatnema commented May 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: remove console logs exposing user data and critical website flows #3845

fix: remove console logs exposing user data and critical website flows #3845

Uh oh!

Conversation

sagarkori143 commented Mar 8, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

netlify bot commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for asyncapi-website ready!

Uh oh!

sambhavgupta0705 commented Apr 6, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagarkori143 commented Apr 11, 2025

Uh oh!

akshatnema commented May 24, 2025

Uh oh!

Uh oh!

Uh oh!

sagarkori143 commented Mar 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 8, 2025 •

edited

Loading

netlify bot commented Mar 8, 2025 •

edited

Loading

codecov bot commented Apr 11, 2025 •

edited

Loading